[1.9] getOverrides (IBakedModel, ItemOverrideList)

[tomevoll]

Can one of these be renamed, when implementing IBakedModel on a ItemOverrideList the functions collide having 2 different return types

[bspkrs]

They shouldn't be colliding if they have different return types.
You're right, this needs to be fixed. Both return types are types of List in one way or another, so they can't coexist.

[matthewprenger]

I'm not seeing the issue here. ItemOverrideList has no getOverrides method.

<Matthew> findm ItemOverrideList\..*
<MCPBot_Reborn> +++ METHODS +++
<MCPBot_Reborn> bpj.a => ItemOverrideList.applyOverride(Lnet/minecraft/item/ItemStack;Lnet/minecraft/world/World;Lnet/minecraft/entity/EntityLivingBase;)Lnet/minecraft/util/ResourceLocation; [ func_188021_a ]
<MCPBot_Reborn> bpj.bpj => ItemOverrideList.ItemOverrideList()V [ ItemOverrideList()V ]
<MCPBot_Reborn> bpj.bpj => ItemOverrideList.ItemOverrideList(Ljava/util/List;)V [ func_i46570_ ]
<Matthew> findm ItemOverrideList\..* 1.9.4
<MCPBot_Reborn> +++ METHODS +++
<MCPBot_Reborn> bon.a => ItemOverrideList.applyOverride(Lnet/minecraft/item/ItemStack;Lnet/minecraft/world/World;Lnet/minecraft/entity/EntityLivingBase;)Lnet/minecraft/util/ResourceLocation; [ func_188021_a ]
<MCPBot_Reborn> bon.bon => ItemOverrideList.ItemOverrideList()V [ ItemOverrideList()V ]
<MCPBot_Reborn> bon.bon => ItemOverrideList.ItemOverrideList(Ljava/util/List;)V [ func_i46570_ ]
<Matthew> findm ItemOverrideList\..* 1.9
<MCPBot_Reborn> +++ METHODS +++
<MCPBot_Reborn> boq.a => ItemOverrideList.applyOverride(Lnet/minecraft/item/ItemStack;Lnet/minecraft/world/World;Lnet/minecraft/entity/EntityLivingBase;)Lnet/minecraft/util/ResourceLocation; [ func_188021_a ]
<MCPBot_Reborn> boq.boq => ItemOverrideList.ItemOverrideList()V [ ItemOverrideList()V ]
<MCPBot_Reborn> boq.boq => ItemOverrideList.ItemOverrideList(Ljava/util/List;)V [ func_i46570_ ]

[kashike]

https://github.com/MinecraftForge/MinecraftForge/blob/1.10.x/patches/minecraft/net/minecraft/client/renderer/block/model/ItemOverrideList.java.patch#L30

[matthewprenger]

@RainWarrior Fry, it looks like you both named this method in MCPBot and committed the conflicting forge patch. Imma let you figure this one out :)

[kashike]

@RainWarrior Do you know what you want to do with this?

[kashike]

Here's another poke, @RainWarrior.

[kashike]

I'm going to go ahead and close this issue based on @RainWarrior's input and lack of comments requesting this.