Colour class cleanup

[bs2609]

• MapColor:

  • field_76281_a: COLORS -> PALETTE ?
  • field_193575_b: BLOCK_COLORS -> DYE_LOOKUP ?
  • field_76291_p: colorValue -> color
  • field_76290_q: colorIndex -> index
  • func_151643_b: getMapColor -> getVariant ?
  • func_193558_a: getBlockColor -> fromDyeColor ?

• EnumDyeColor:

  • field_193351_w: colorValue -> color
  • field_193352_x: colorComponentValues -> colorComponents
  • func_192396_c: getDyeColorName -> getResourceName ?
  • func_193350_e: getColorValue -> getColor
  • func_193349_f: getColorComponentValues -> getColorComponents

[liach]

Is field_193351_w a java awt color?

[Pokechu22]

It's an int, probably in RGB or ARGB form.

[liach]

I'd like an specification on if that field is rgb or argb, either in the field name or javadocs.

[Pokechu22]

Done for EnumDyeColor (only javadocs; I can't rename things):

field_193351_w

An int containing the corresponding RGB color for this dye color.

field_193352_x

An array containing 3 floats ranging from 0.0 to 1.0: the red, green, and blue components of the corresponding color.

func_193350_e

Gets the RGB color corresponding to this dye color.

func_193349_f

Gets an array containing 3 floats ranging from 0.0 to 1.0: the red, green, and blue components of the corresponding color.

[liach]

Thanks!

[kashike]

• field_193560_ab: BLACK_STAINED_HARDENED_CLAY → BLACK_TERRACOTTA
• field_193572_X: BLUE_STAINED_HARDENED_CLAY → BLUE_TERRACOTTA
• field_193573_Y: BROWN_STAINED_HARDENED_CLAY → BROWN_TERRACOTTA
• field_193570_V: CYAN_STAINED_HARDENED_CLAY → CYAN_TERRACOTTA
• field_193568_T: GRAY_STAINED_HARDENED_CLAY → GRAY_TERRACOTTA
• field_193574_Z: GREEN_STAINED_HARDENED_CLAY → GREEN_TERRACOTTA
• field_193564_P: LIGHT_BLUE_STAINED_HARDENED_CLAY → LIGHT_BLUE_TERRACOTTA
• field_197655_T: LIGHT_GRAY_STAINED_HARDENED_CLAY → LIGHT_GRAY_TERRACOTTA
• field_193566_R: LIME_STAINED_HARDENED_CLAY → LIME_TERRACOTTA
• field_193563_O: MAGENTA_STAINED_HARDENED_CLAY → MAGENTA_TERRACOTTA
• field_193562_N: ORANGE_STAINED_HARDENED_CLAY → ORANGE_TERRACOTTA
• field_193567_S: PINK_STAINED_HARDENED_CLAY → PINK_TERRACOTTA
• field_193571_W: PURPLE_STAINED_HARDENED_CLAY → PURPLE_TERRACOTTA
• field_193559_aa: RED_STAINED_HARDENED_CLAY → RED_TERRACOTTA
• field_193561_M: WHITE_STAINED_HARDENED_CLAY → WHITE_TERRACOTTA
• field_193565_Q: YELLOW_STAINED_HARDENED_CLAY → YELLOW_TERRACOTTA
• field_151659_e: CLOTH → WOOL

[bs2609]

On that note:

• field_151654_J: OBSIDIAN -> SPRUCE ?

I'll let this excerpt from the vanilla wiki speak for itself here: