World.isRemote -> World.isClient

[Runemoro]

• field_72995_K in net.minecraft.world.World: isRemote -> isClient

The field is set from only two places, the constructors of the WorldClient and WorldServer subclasses:

Also, the name isRemote is simply wrong. If I understand correctly, the word "remote" means "on the other side" (so client-side in server-side code, and server-side from client-side code). That would mean that the field should always be false, since WorldServers are only used server-side and WorldClients are only used client-side.

[ZeroMemes]

I would recommend taking a look at #42. lol

[tterrag1098]

isClient would be inaccurate, as most would consider the integrated server to be on the "client"

Plus, the name is never going to be changed, as was lengthily discussed in #42

[Runemoro]

isClient would be inaccurate, as most would consider the integrated server to be on the "client"

Then a different name should be given to the field (as well as the WorldServer class, since that's on the integrated server too).

I don't see how the client could be considered "remote" both by server-side code and by client-side code.

Also, the comments on issue #42 are either wrong or outdated:

isRemote says that the World comes from the remote server, not the local client.

This is false, isRemote is true when the world is on the client, not server.

I would actually consider proposing a rename to isSourceRemote or something similar, to make it clear what the situation is. Or possible updating the javadocs, with something like True if this world was sent to the caller over the network (i.e., client), false if it was sourced locally (server).

isRemote is true for all client worlds, even the WorldClient instance in Minecraft which was not sent over the network...

[tterrag1098]

The server is authoritative, the client thread is always "remote" to it.

[Runemoro]

No, Minecraft.world.isRemote is true even when called on the client thread, despite the client thread not being remote to itself.

[tterrag1098]

That makes no sense at all. Again the server is in control, the data is always relative to the server. The client world needs to be able to introspectively know if it is remote to the server. The client world is NOT in control so it is remote. End of discussion.