Skip to content

Add support for ion-tabs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Add support for ion-tabs #9

merged 3 commits into from
Mar 4, 2019

Conversation

michaeltintiuc
Copy link
Member

Add support for ion-tabs.

The implementation creates only a single Vue component for ion-tabs, the rest of the functionality is kept as a web component.

Custom features:

  • Ability to pass a string or an array of strings of route names to match tabs against to ion-tab (via :routes attribute)
  • Ability to pass an object containing route data to ion-tab-button, identical to <router-link> (via :to attribute)
  • Ability to pass a custom click handler to ion-tab-button

Since ion-tabs require a router, I have exported the existing ionic/vue router.

Quality of Life improvements:

  • Fixed broken controller cache, as it would the createApi method without fetching cached objects.
  • Updates for @ionic/core v4 stable release
  • Updated usage docs for ion-tabs

Copy link
Member

@grgur grgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@michaeltintiuc michaeltintiuc merged commit dd272f6 into master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants