New Field Type: EmbeddedDocumentListField

[gordol]

Basically same as ListField but provides some additional query helpers.

Field docs here and query docs here.

[AlmogCohen]

+1

[wojcikstefan]

EmbeddedDocumentListField already exists in MongoEngine (see https://github.com/MongoEngine/mongoengine/blob/master/mongoengine/fields.py#L718). Or did I misunderstand the issue?

[gordol]

@wojcikstefan Why did you close this? You are indeed misunderstanding I think...

I know EmbeddedDocumentListField exists in mongoengine already, I even linked to their documentation. The links are broken now, but here are the latest:

field docs: http://docs.mongoengine.org/apireference.html#mongoengine.fields.EmbeddedDocumentListField

query docs:
http://docs.mongoengine.org/apireference.html#embedded-document-querying

EmbeddedDocumentListFields are NOT SUPPORTED by flask-mongoengine. That is why I opened this issue.

There is no WTF convertor defined for EmbeddedDocumentListFields. There are convertors for EmbeddedDocuments, and for ListFields, but that is not sufficient. EmbeddedDocumentListFields have additional functionality that is not the same as a ListField of EmbeddedDocument fields.

[wojcikstefan]

There is no WTF convertor defined for EmbeddedDocumentListFields. There are convertors for EmbeddedDocuments, and for ListFields, but that is not sufficient. EmbeddedDocumentListFields have additional functionality that is not the same as a ListField of EmbeddedDocument fields.

Ah, thanks for clarifying. I didn't infer from the original description that you're talking about supporting this field via the WTF model form. That's definitely worth looking into. Would you like to give it a shot and send a PR?

[gordol]

Indeed I would love to, but my time is limited until January. I can take a shot at it then, however.

[wojcikstefan]

Great! I'll let you know if I get a chance to look at it earlier. If not, looking forward to Jan! :)

[xyzones]

Any chance to implement this?

[gordol]

Nope, I've just been using db.ListField(db.EmbeddedDocumentField()) :(

I think maybe all we need to do is add a converter here?

flask-mongoengine/flask_mongoengine/wtf/orm.py

Line 161 in 56caa8a

def conv_List(self, model, field, kwargs):

flask-mongoengine/flask_mongoengine/wtf/orm.py

Line 192 in 56caa8a

def conv_EmbeddedDocument(self, model, field, kwargs):

Something that merges these two?

Anything new for this issue?

[devinclary]

+1