Add support for Flask-WTF 0.14 #296
Conversation
|
Thanks @jcass77 for the contribution. |
| def __init__(self, formdata=None, obj=None, **kwargs): | ||
| self.instance = (kwargs.pop('instance', None) or obj) | ||
| def __init__(self, formdata=None, **kwargs): | ||
| self.instance = (kwargs.pop('instance', None) or kwargs.get('obj')) |
There was a problem hiding this comment.
...thinking about this some more, this should probably be kwargs.get('obj', None) to avoid a KeyError being raised seeing as this is an optional parameter.
Do I need to submit a new PR or will somebody with commit access just make the change?
There was a problem hiding this comment.
Hmmm... dict.get defaults to None, right?
assert {'a':1, 'b':2}.get('d') is None
(This is inconsistent with getattr and I was already struck by it once recently.)
Thanks anyway for taking the time to review your own code again. I appreciate.
And considering the little time we dedicate to the maintenance of flask-mongoengine, a PR is appreciated, even for a trivial change.
There was a problem hiding this comment.
Ah, without checking, I assumed that the code would produce the same result as {'a':1, 'b':2}['d'] - my bad.
As far as I could tell, these are the only changes required to get the test back to green.
None of the CSRF-related changes appear to affect flask-mongoengine (so far).