Fix test and mongomock #304
Merged
+82
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, you do!
I'm sorry, I can't do that right now. I'm gonna trust you and @wojcikstefan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include #303 (it takes it as a starting point).
It fix the support of mongomock (you can either pass a
MONGODB_USE_MOCK=Trueflag in flask's config or use themongomock://prefix in the host)It fix the unittests that where silently failing: MongoEngine keep a global state of the connection but this wasn't clean before each test, hence some of them were using an old connection state which...
@lafrech I don't have commit right to this repo, can you review, merge&release for me ? ;-)