chore: empty default implementation for RenderSystem interface #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added
Topic: Rendering
skaldarnar
added a commit
to Terasology/Health
that referenced
this pull request
Jun 24, 2021
pollend
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
I noticed a bit of clutter boilerplate code in a system implementing
RenderSystembecause of empty implementations of the method hooks for different rendering passes. With Java's default implementations for methods in interfaces we get rid of this boilerplate code by providing the empty implementation directly in the interface.How to test
Start the game, everything should look and work the same as before.
Outstanding before merging
Nothing.