refactor: construct block mesh generator single shape with standard mesh data #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
pollend
added a commit
to Terasology/FlowingLiquids
that referenced
this pull request
Sep 6, 2021
pollend
changed the title
github-actions
bot
added
the
Type: Refactoring
jdrueckert
reviewed
Nov 2, 2021
.../src/main/java/org/terasology/engine/rendering/primitives/BlockMeshGeneratorSingleShape.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/rendering/primitives/BlockMeshShapeGenerator.java
Outdated
Show resolved
Hide resolved
pollend
force-pushed
the
chore/use-StandardMeshData-directly-constructing-BlockMeshGeneratorSingleShape
branch
from
c572b10
to
dac67fc
Compare
…ructing-BlockMeshGeneratorSingleShape
jdrueckert
approved these changes
Nov 27, 2021
jdrueckert
changed the title
jdrueckert
deleted the
chore/use-StandardMeshData-directly-constructing-BlockMeshGeneratorSingleShape
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing what the tesselator used to look like before the attribute changes I think its a pretty straightforward change to drop the use of the Tesselator and submit the mesh data directly. The code is already to a degree simpler so Tesselator does not seem appropriate anymore. The only other place this is referenced is within flowing liquids so I could just move this up into the interface as a default maybe?
https://github.com/MovingBlocks/Terasology/blob/c725b454517bcaec881c343d5045eb76d722868b/engine/src/main/java/org/terasology/engine/rendering/primitives/Tessellator.java