Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add test cases for vertex resource and update api with put and replace #4905

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

pollend
Copy link
Member

@pollend pollend commented Sep 12, 2021

refactored vertex resource with updated javadocs, more tests and tried to make test cases more consistent

  • replaced copyBuffer with replace
    • this will replace the contents of a buffer with the target one
  • introduced put commend
    • will take a bytebuffer or buffered resource and append it to the existing.

@github-actions github-actions bot added the Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity label Sep 12, 2021
Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, as far as I can tell, even if I can't say I necessarily get any of it - but this is likely to not get such detailed review anyway these days, so merging anyway. Tests pass (yay more tests and doc), game runs 👍

@Cervator Cervator merged commit ae49f9f into develop Oct 4, 2021
@Cervator Cervator deleted the refactor/rework-vertex-resource-more-test-cases branch October 4, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants