Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use logger instead of System.out.println #5188

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Dec 4, 2023

would it be acceptable to you to use logger instead of system out in these cases?

Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logger changes seem fine to me. I will leave the LOGGER vs logger bit for others to decide upon.

I am a bit more concerned about the changes to the tools in the engine-tests/src/test/java/org/terasology/documentation folder. I suspect that these tools may have been intentionally not using a logging framework.

@soloturn soloturn force-pushed the qa/no-println branch 2 times, most recently from af160ce to 8f08b52 Compare December 9, 2023 12:26
@soloturn soloturn force-pushed the qa/no-println branch 2 times, most recently from 703bb14 to 59f865d Compare January 4, 2024 22:02
Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ApiScraper and ApiComparator tools were introduced in #3253. As far as I can tell, they were never used and I am unsure about how to test them directly. The output appears to be intended as more human readable than machine readable, so the logger changes may not be significantly detrimental here. Either way, merging is is unlikely to break anything, since this code appears to be unused.

The rest of the changes raise no concerns for me.

I am approving this but would still prefer a second opinion before merging.

@jdrueckert jdrueckert changed the title Qa/no println refactor: use logger instead of System.out.println Jan 21, 2024
@github-actions github-actions bot added the Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity label Jan 21, 2024
@jdrueckert jdrueckert merged commit dbb0dae into develop Jan 21, 2024
9 checks passed
@jdrueckert jdrueckert deleted the qa/no-println branch January 21, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants