Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offer some useful things during copy #5346

Merged
merged 5 commits into from
Sep 30, 2020
Merged

offer some useful things during copy #5346

merged 5 commits into from
Sep 30, 2020

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Sep 29, 2020

Closes #4959

introduces two buttons on the Copy interface:

image

The first button expands all fields - this button will automatically be pressed by the page itself if there are any errors on the page (e.g. a user changed the slug for EN and just clicked "COPY" rather than expanding the locale fields to make sure all localized slugs were updated, too).

The second button simply takes the current values in all [EN] fields (technically, all default language fields, but for our site that's EN) and copies those over to all corresponding localized fields.

@Pomax Pomax requested a review from KalobTaulien September 29, 2020 23:04
@mofodevops mofodevops temporarily deployed to foundation-s-fix-copy-p-dfw6zd September 29, 2020 23:04 Inactive
@Pomax Pomax temporarily deployed to foundation-s-fix-copy-p-dfw6zd September 29, 2020 23:05 Inactive
@Pomax Pomax temporarily deployed to foundation-s-fix-copy-p-dfw6zd September 29, 2020 23:07 Inactive
@Pomax Pomax temporarily deployed to foundation-s-fix-copy-p-dfw6zd September 30, 2020 15:00 Inactive
Copy link
Contributor

@KalobTaulien KalobTaulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pomax Pomax temporarily deployed to foundation-s-fix-copy-p-dfw6zd September 30, 2020 17:07 Inactive
@Pomax Pomax merged commit 68c5032 into master Sep 30, 2020
@Pomax Pomax deleted the fix-copy-page branch September 30, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force-update title/slug fields for all locales when copying a page
3 participants