Skip to content

CoreX v0.45.1

Choose a tag to compare

View all tags
@MustafaShaaban MustafaShaaban released this 11 Oct 20:06
· 113 commits to main since this release
v0.45.1
d4e87d4
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

One fix, reported from a client site on v0.45.0: a file sent with a form could not be opened from its submission. Under "Answers" in the Submissions inbox there was the number the file is stored under and nothing to press. The pane now shows the file's name as a link, an export names the file, and who may open it is who may read the submission.

Nothing to set and nothing to rebuild. Two things are not changed by it and are still wrong: the notification email of a form with a file prints that number and carries no file, and CoreX → Data → Form submissions prints it too.

Fixed

  • A file sent with a form is opened from its submission (spec 081, Phase F; DECISIONS #317). Reported from a client site on v0.45.0: under "Answers" in the Submissions inbox, a submission that carried a file showed the number the file is stored under (224) and nothing to press. The pane now shows the file's name as a link, and pressing it downloads the file. It says "File missing" when the file is gone, and a file question nobody answered is not listed. The same in the trash, until the submission is deleted for good.
  • Who may open it is who may read the submission. The link is to an address of the submission's own, checked on every request against the inbox's rule: the person manages submissions and their scope allows that one. A role that was given the inbox and is not an editor opens the file; an editor who was not given the inbox does not. Signed out, or with a link made for somebody else, no file is given.
  • A submissions export names the file. A file's column held the same number. It holds the file's name, or "File missing".

Client impact

  • Nothing to set, and nothing to rebuild: no script or stylesheet changed.
  • A site whose own code reads GET corex/v1/submissions/{id} finds, for a file's answer, an object (id, name, url, missing) where there was a number.
  • Not changed by this, and still wrong: the notification email of a form with a file prints that number and carries no file, and CoreX → Data → Form submissions prints it too. Both are in PROGRESS.md under "Open, and not hidden".
Assets 2
Loading