Skip to content

Commit 67cb4ff

Browse files
committed
fix some cli-related problems I just introduced
add an option for fast-denoise
1 parent fd8f177 commit 67cb4ff

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

trunk/export/generic.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ package export::generic;
266266
my $arg = shift;
267267
if (!defined $self->{$arg}) {
268268
# Look for a config option, a commandline option, or the code-specified default
269-
$self->{$arg} = arg($arg, $self->{'defaults'}{$arg});
269+
$self->{$arg} = arg($arg, $self->{'defaults'}{$arg}, $self);
270270
}
271271
return $self->{$arg};
272272
}

trunk/nuv_export/cli.pm

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,13 @@ package nuv_export::cli;
168168

169169
# Retrieve the value of a commandline argument
170170
sub arg {
171-
my ($arg, $default) = @_;
171+
my $arg = lc(shift);
172+
my $default = shift;
173+
my $package = lc(shift or (caller())[0]);
172174
# Commandline preference/override
173175
return $args{$arg} if (defined($args{$arg}));
174176
# Load rc preference
175-
$args{$arg} = rc_arg($arg);
177+
$args{$arg} = rc_arg($arg, $package);
176178
# Return the rc preference, or the passed-in default value
177179
return defined($args{$arg})
178180
? $args{$arg}

trunk/nuvexportrc

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,18 @@
7979
#
8080

8181
<ffmpeg>
82-
noise_reduction = no
82+
#
83+
# ffmpeg is almost twice as fast if you disable noise reduction
84+
#
85+
# noise_reduction = no
86+
#
87+
# If you have a clean signal, you might want to try to use fast_denoise
88+
# with ffmpeg (it's actually part of yuvdenoise, which the ffmpeg exporter
89+
# uses). It can be almost twice as fast as normal noise reduction, but is
90+
# nowhere near as effective.
91+
#
92+
# fast_denoise = yes
93+
#
8394
</ffmpeg>
8495

8596
<transcode>

0 commit comments

Comments
 (0)