Skip to content

Commit 3ab178d

Browse files
committed
Do not lower case when comparing paths, these are case sensitive comparisons and can result in broken paths being used.
(cherry picked from commit cfdd72e)
1 parent 1509627 commit 3ab178d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

mythplugins/mythmusic/mythmusic/filescanner.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ FileScanner::FileScanner ()
2222
MSqlQuery query(MSqlQuery::InitCon());
2323

2424
// Cache the directory ids from the database
25-
query.prepare("SELECT directory_id, LOWER(path) FROM music_directories");
25+
query.prepare("SELECT directory_id, path FROM music_directories");
2626
if (query.exec())
2727
{
2828
while(query.next())
@@ -109,12 +109,12 @@ void FileScanner::BuildFileList(QString &directory, MusicLoadedMap &music_files,
109109
QString dir(filename);
110110
dir.remove(0, m_startdir.length());
111111

112-
newparentid = m_directoryid[dir.toLower()];
112+
newparentid = m_directoryid[dir];
113113

114114
if (newparentid == 0)
115115
{
116116
int id = GetDirectoryId(dir, parentid);
117-
m_directoryid[dir.toLower()] = id;
117+
m_directoryid[dir] = id;
118118

119119
if (id > 0)
120120
{
@@ -252,7 +252,7 @@ void FileScanner::AddFileToDB(const QString &filename)
252252
query.prepare("INSERT INTO music_albumart SET filename = :FILE, "
253253
"directory_id = :DIRID, imagetype = :TYPE;");
254254
query.bindValue(":FILE", name);
255-
query.bindValue(":DIRID", m_directoryid[directory.toLower()]);
255+
query.bindValue(":DIRID", m_directoryid[directory]);
256256
query.bindValue(":TYPE", AlbumArtImages::guessImageType(name));
257257

258258
if (!query.exec() || query.numRowsAffected() <= 0)
@@ -273,7 +273,7 @@ void FileScanner::AddFileToDB(const QString &filename)
273273
QString album_cache_string;
274274

275275
// Set values from cache
276-
int did = m_directoryid[directory.toLower()];
276+
int did = m_directoryid[directory];
277277
if (did > 0)
278278
data->setDirectoryId(did);
279279

@@ -444,7 +444,7 @@ void FileScanner::RemoveFileFromDB (const QString &filename)
444444
query.prepare("DELETE FROM music_albumart WHERE filename= :FILE AND "
445445
"directory_id= :DIRID;");
446446
query.bindValue(":FILE", sqlfilename);
447-
query.bindValue(":DIRID", m_directoryid[directory.toLower()]);
447+
query.bindValue(":DIRID", m_directoryid[directory]);
448448

449449
if (!query.exec() || query.numRowsAffected() <= 0)
450450
{
@@ -489,7 +489,7 @@ void FileScanner::UpdateFileInDB(const QString &filename)
489489
QString album_cache_string;
490490

491491
// Set values from cache
492-
int did = m_directoryid[directory.toLower()];
492+
int did = m_directoryid[directory];
493493
if (did > 0)
494494
disk_meta->setDirectoryId(did);
495495

0 commit comments

Comments
 (0)