Skip to content

Commit cb01f30

Browse files
k-rosssphery
authored andcommitted
Fix MythPlayer::GetRawVideoFrame() for mythcommflag.
Fix MythPlayer::GetRawVideoFrame() to return the correct frame number. This change fixes mythcommflag so that it will return consistent results across multiple runs. It should also improve commercial detection accuracy, as the frame numbers identified by the different methods will actually be precise--allowing for better comparing the results of the different methods. Although this commit has my name for the signed-off line, I didn't do much. Thanks to Kevin Ross for the debugging and the patch, to Taylor Ralph and Mark Kendall for actually reviewing the patch, and to all the users and devs who ran with the patch to test it (and saw greatly-improved commercial flagging results). Fixes #9997. Signed-off-by: Michael T. Dean <mdean@mythtv.org> (cherry picked from commit f135d5d)
1 parent a24ecbf commit cb01f30

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mythtv/libs/libmythtv/mythplayer.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4089,7 +4089,8 @@ VideoFrame* MythPlayer::GetRawVideoFrame(long long frameNumber)
40894089
VERBOSE(VB_PLAYBACK, LOC + QString("Waited 100ms for video frame"));
40904090
}
40914091

4092-
return videoOutput->GetLastDecodedFrame();
4092+
videoOutput->StartDisplayingFrame();
4093+
return videoOutput->GetLastShownFrame();
40934094
}
40944095

40954096
QString MythPlayer::GetEncodingType(void) const

0 commit comments

Comments
 (0)