Repository navigation
v1.2.0
·
153 commits
to main
since this release
Immutable
release. Only release title and notes can be modified.
Added
- A
/reviewcomment from someone with write access that starts with/reviewand then a space or the end of the comment but isn't a command, such as/review please, gets a 😕 reaction within seconds, so its author can tell that no review started; the run's log lists the commands. The reaction uses a token of its own that holds only the pull requests permission, minted before setup-node and revoked before the review step, and never in the review step's environment (#174, ADR-1004). npm run trainlearns from the review bot's own findings that the maintainer answered, one source per pull request with the replies and whether each finding was fixed or declined: a decline with a lasting reason teaches reviewers what not to report, and a fix the rule it enforced. Only the maintainer's replies count (ADR-1005).
Changed
- The repository follows project-template v0.68.4 (from v0.59.0): the
Commit attributioncheck and thecommit-msghook catch attribution from any AI agent or model, and the check's remedy for an attribution line in a commit message runs the hook, asCONTRIBUTING.mdnow says; the workflow commands remove an agent footer a session appends to what they post, except on a/reviewcomment, which/run-issuesand/run-feedbackleave as posted because NCode Review reads the command from its first line; the commands that callghuse its REST forms in a session that refuses GitHub's GraphQL API, such as a Claude Code cloud session;/address-feedbackand/run-feedbackalso run in Copilot Chat and Copilot CLI and finish a run that stopped, also one the other tool started;.template/Update-Project.ps1stages only the files an update changes; andAGENTS.md's Landing section setspre-release: tracked, the template's new key, as it is for a project with releases. - The repository follows project-template v0.75.1 (from v0.68.4): Claude Code sessions run Bash and PowerShell commands without asking, except
git pushand a command that mentions.envorsecrets, and a Claude Code cloud session installspwshwhen its container lacks it;/ship-plancan mark follow-ups to act on next, which/finish-planthen names as/plan-issueruns; the Copilot setup workflow runs again when.node-versionchanges; and.template/Initialize-Nvs.ps1sets nvs up once per PC, asCONTRIBUTING.mdsays. The template'stag-release.ymlpublishes nothing here, becausereleasestaysnone: releases stay manual throughrelease.yml, theRelease (manual)workflow in the Actions tab. - The repository follows project-template v0.83.0 (from v0.75.1): nothing checks commits or pull requests for AI agent attribution, so the
Commit attributionCI job,.template/Test-CommitAttribution.ps1and the.githooks/commit-msghook are removed, andCONTRIBUTING.mdasks contributors to avoid it (the template's ADR-0018); CI doesn't run again when a pull request's title or description is edited; a Claude Code cloud session runs each.claude/hooks/ensure-*.shat start, which installspwshand the.node-versionNode.js;/run-issuesand/ship-plancan fix a plan's follow-ups in its pull request before merge; and plans can land through a branch a session's host made for it. The prelude is the template's.template/Use-Node.ps1, which accepts the.node-versionNode.js already onPATHwhere nvs isn't installed, andtools/Use-Node.ps1is removed (ADR-1003). - The repository follows project-template v0.84.1 (from v0.83.0):
.template/Update-Project.ps1stages every change outside the conflicting files, deletions included, when it stops on a conflict, and leaves a catch-all text rule such as* text eol=lfout of the.gitattributeslines an adopted project kept;/plan-template-updateleaves a deletion an older target's script left unstaged unmarked, so its commit note stages it (#181). - The repository follows project-template v0.84.3 (from v0.84.1): the workflow commands record a Claude Code cloud session's push branch without remarking on it, and
/ship-plannames the branch it pushes to in the summary it shows before it pushes; Claude Code's planning commands enable.githooksand record the session's push branch from the main checkout before they enter the plan's worktree, and/run-issuesand/address-feedbackcheck the hooks before they create theirs; and theaskrules in.claude/settings.jsonmatch a command that mentions the rootsecrets/folder, not any text containingsecrets, so a source folder namedSecretsno longer asks for approval. - The repository follows project-template v0.86.1 (from v0.84.3): Copilot Chat, Copilot CLI and the VS Code agents keep each plan in its own git worktree under
.claude/worktrees/, as Claude Code does, asCONTRIBUTING.mdsays;/run-issuesand/address-feedbackin Copilot work in worktrees of their own and never switch the main checkout, and/run-issuesin every tool runs the next entry ahead in its own worktree while a draft pull request waits, then lands the entries one at a time, in queue order;/analyze-architectureand/analyze-decisionwork in a worktree of their own, whereANALYSIS.mdstays untracked and a decision record lands with the plan made there, asdocs/decisions/README.mdsays, and/continue-planlists and/finish-planremoves such worktrees; and/finish-planfast-forwards the default branch without switching a checkout that holds other work. - The reviewers settle in the checkout what they would otherwise ask, and don't report a production rule in test code or a C# rule in a script, a rule a line broke before a change that only renames or renumbers on it, compatibility or migration notes in a repository whose conventions say it is pre-release, another repository's process rules, duplication between places that can't share code, a parameter the conventions require as unused, or a date against today's. The rule check reports only what the change writes, synthesis merges one problem raised at several places in one file into one finding,
testsnames the search behind a missing test, anddata-modelandapi-compatexpect no earlier data or callers where nothing is released (ADR-1005). - The learned guidance is regenerated from NCodeGroup/identity, identity-platform and project-template: their decision records, instruction files and review prompts, and the bot's findings the maintainer answered on their pull requests. It holds 1,234 rules, 157 of them on what not to report; production and test rules name their scope; and the rules of decision records that no longer exist are gone (#190).
- A release is made by merging: a plan whose change reaches consumers carries a
Release:line, its last step dates the changelog section, and merging its pull request tags and publishes the release, so nobody runsrelease.yml, which stays as the fallback. This repository's own pin of NCode Review is set to follow a release within a weekday: itsgithub-actionsDependabot entry runs daily and its cooldown excludes the action, which Dependabot's documentation doesn't say applies togithub-actions, so without it the bump waits the 3 days (#196, ADR-1006).
Fixed
- A training run deletes the rules it extracted from a source the repository no longer has, such as a renumbered decision record, so they no longer reach the guidance;
--repofinds the repository's extraction folder ignoring case; and a rule learned from an instruction file for production or test code says which, so reviewers no longer apply production rules to test projects (ADR-1005). - Training reads a repository's pull request comments one page at a time, by number, so it runs behind a proxy that refuses GitHub's next-page links, such as a Claude Code cloud session's.