Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth breaking DB1 bug #7

Closed
ajhenrique opened this issue Apr 4, 2019 · 1 comment
Closed

Depth breaking DB1 bug #7

ajhenrique opened this issue Apr 4, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
6.07.X Public Rel...

Comments

@ajhenrique
Copy link
Collaborator

DB1 module was originally coded using the monocramatic wave dissipation dimensional variables. It was updated to use the spectral form, but some coefficients were no updated accordingly which resulted in a dimensionally-incorrect version. @aronroland @ajhenrique and @thesser1 are working to fix this inconsistency.
@ajhenrique ajhenrique added the bug Something isn't working label Apr 4, 2019
This was referenced Apr 5, 2019
Closed
Merged
@ajhenrique
Copy link
Collaborator Author

Issue has been solved.

@ajhenrique ajhenrique mentioned this issue Apr 19, 2019
Merged
ajhenrique added a commit that referenced this issue Apr 19, 2019
@ajhenrique
HF ounfpart + NCO switch + DB1 coeff (#14)
b582f8c 
Merging Hotfixes branch HF_ounfpart into the WW3 master. 

* Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2.
* Updating link.wcoss_phase2 for grib compile, removing !$ lines in ww3_uprstr that broke compilation of codes with OMPH OMPG switch flags, added new global wave model switch. Added option for writing to fixed netcdf gridded output file when using NCO switch (the issue will be fixed more adequately in v7 following Issue #8).
* DB1 depth-breaking_bugfix: added proper scaling coefficients for radian freq. [radHz]. See issue #7.

Merge will lead to v6.07.1, tag and release will be updated accordingly.
@ajhenrique ajhenrique mentioned this issue Apr 23, 2019
Merged
ajhenrique added a commit that referenced this issue Apr 23, 2019
@ajhenrique
HotFix: ounfpart + NCO switch + DB1 coeff (v6.07.1) (#16)
2b1ea78 
HF ounfpart integrates hotfixes from the NCEP/NOAA-EMC auth repo and the trusted repos UKMO and ERDC. The following hotfixes are implemented with this pull request:

* Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2.
* Updating link.wcoss_phase2 for grib compile, removing !$ lines in ww3_uprstr that broke compilation of codes with OMPH OMPG switch flags, added new global wave model switch.
* Added option for writing to fixed netcdf gridded output file when using NCO switch (the issue will be fixed more adequately in v7 following Issue #8).
* DB1 depth-breaking_bugfix: added proper scaling coefficients for radian freq. [radHz]. See issue #7 .

Hotfixes were tested using the full regression testing matrix at NCEP which resulted in differences only in regtests wher DB1 was employed, as expected.
@ajhenrique ajhenrique mentioned this issue Apr 25, 2019
Closed
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Sep 26, 2019
Closed
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Oct 3, 2019
Closed
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Jan 22, 2020
Closed
@iman-j iman-j mentioned this issue Feb 25, 2020
Closed
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Jun 28, 2020
Closed
aliabdolali pushed a commit that referenced this issue Sep 25, 2020
@ukmo-ccbunney @CarstenHansen @ukmo-juan-castillo
UKMO Staging [fb_rtd2, bf_coupling condition, bf_smc_omp] (#254)
aea3e57 
* Fb rtd2 (#7)

FB_rtd2: Output boundary conditions to rotated grids

* This feature allows the user to specify the pole of each nested grid output of boundary conditions (nest) file.
  - There is no effect unless the switch RTD is set for compilation.
  - The contents of b.c. output files nestI.ww3 are not affected.
  - A model compiled with combined switches SMC and RTD is not affected.

* Updated manual Sec. "3.4.9 Rotated grids"

* Added regtests for testing input/output BCs in rotated pole context.

* Updated revision of ww3_bound.ftn to 7.11

* Added new ww3_tr1 regtest (rotated pole) to matrix.base. Also, split the SMC/RTD regtests into their own separate switches.

Co-authored-by: ukmo-chris.bunney <christopher.bunney@metoffice.gov.uk>

* Double allocation error of FIELD variable [w3wavemd] (#14)

* Fixed allocation of FIELD variable.
* Removed defunct OMPX switches and FLOMP variable

* Change coupling condition so that it works with all compilers (#12)

Co-authored-by: Carsten Hansen <cha@fcoo.dk>
Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
DeniseWorthen referenced this issue in DeniseWorthen/WW3 Dec 8, 2021
@DeniseWorthen
runs several hours, then
c2af315 
 #7  0x0000000001b384f1 in setglobalinput (
    importstate=<error reading variable: Cannot access memory at address 0x7ffe86fde000>, fldname=..., vm=..., global_output=..., rc=0,
   .tmp.FLDNAME.len_V$7b73=0)
    at /glade/work/worthen/ufs_ww3debug/WW3/model/src/wav_import_export.F90:1483
 #8  0x0000000001b37cb6 in wav_import_export::import_fields (
JessicaMeixner-NOAA added a commit to JessicaMeixner-NOAA/WW3 that referenced this issue Feb 22, 2022
@JessicaMeixner-NOAA @mickaelaccensi @MatthewMasarik-NOAA
fix grib build (NOAA-EMC#7)
dfb5e00 
* non interactive ww3_from_ftp.sh  NOAA-EMC#603

* uniformize regtests output by setting a global output type in the matrix script (NOAA-EMC#605)

* ww3_doxy_tmpl.md: clarify MODULE markup (NOAA-EMC#606)

* namelist feature for program ww3_bound (NOAA-EMC#610)

* doxygen: remove existing doxygen errors prior to markup (NOAA-EMC#611)

* update to not force grib build

* fix typo

Co-authored-by: Mickael Accensi <49198861+mickaelaccensi@users.noreply.github.com>
Co-authored-by: Matthew Masarik <86749872+MatthewMasarik-NOAA@users.noreply.github.com>
This was referenced Aug 23, 2022
Open
Closed
@JMSnyder1980 JMSnyder1980 mentioned this issue Feb 15, 2023
Closed
MatthewMasarik-NOAA added a commit that referenced this issue Oct 18, 2023
@MatthewMasarik-NOAA
Buoy stats and metrics: wrapper scripts added (#7)
8dd7201 
buoy stats and metrics: python and bash wrapper scripts added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
6.07.X Public Release version hotfixes
Development

No branches or pull requests
1 participant
@ajhenrique