fix: improve react-scripts version detection

Author: Nargonath

README.md

@@ -82,7 +82,7 @@ If those defaults do not work for you, the script accepts some arguments:
 
 * `-b|--build-path`: expects either an absolute or relative path. If a relative path is given it will be prefixed by your project root path.
   * default: `yourProjectRoot/build`.
-* `--react-scripts-version`: expects the `react-scripts` version you are using in your project i.e `2.0.3`. If not given it will be implied from your package.json and if it cannot be implied the version `2.0.4` will be the default. Consider setting it if you ejected.
+* `--react-scripts-version`: expects the `react-scripts` version you are using in your project i.e `2.0.3`. If not given it will be implied from your `node_modules` and if it cannot be implied the version `2.0.4` will be the default. Consider setting it if you ejected.
 * `-p|--public-path`: expects a relative URL where `/` is the root. If you serve your files using an external webserver this argument is to match with your web server configuration. More information can be found in [webpack configuration guide](https://webpack.js.org/configuration/output/#output-publicpath).
   * default: "".
 * `-v|--verbose`: display webpack build output.

utils/index.js

@@ -11,7 +11,7 @@ const DEFAULT_VERSION = {
   patch: 4,
 };
 
-exports.isEjected = fs.pathExistsSync(path.join(process.cwd(), 'config/paths.js'))
+exports.isEjected = fs.pathExistsSync(path.join(process.cwd(), 'config/paths.js'));
 
 exports.getReactScriptsVersion = function getReactScriptsVersion(cliVersion) {
   if (cliVersion) {
@@ -23,16 +23,16 @@ exports.getReactScriptsVersion = function getReactScriptsVersion(cliVersion) {
     return versions;
   }
 
-  const packageJson = importCwd.silent('./package.json');
-  if (!packageJson || !packageJson.dependencies['react-scripts']) {
+  const reactScriptsPkg = importCwd.silent('react-scripts/package.json');
+  if (!reactScriptsPkg || !reactScriptsPkg.version) {
     return DEFAULT_VERSION;
   }
 
-  const { dependencies } = packageJson;
+  const { version } = reactScriptsPkg;
   const versions = {
-    major: Number(semver.major(dependencies['react-scripts'])),
-    minor: Number(semver.minor(dependencies['react-scripts'])),
-    patch: Number(semver.patch(dependencies['react-scripts'])),
+    major: Number(semver.major(version)),
+    minor: Number(semver.minor(version)),
+    patch: Number(semver.patch(version)),
   };
   return versions;
 };