Refactor include gradle #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
Plamen5kov
reviewed
Jul 26, 2017
petekanev
commented
Aug 2, 2017
| //////////////////////////////////////////////////////////////////////////////////// | ||
| ///////////////////////////// CONFIGURATION PHASE ////////////////////////////////// | ||
| //////////////////////////////////////////////////////////////////////////////////// | ||
| task applyAppGradleConfiguration { |
There was a problem hiding this comment.
finalizes applyPluginsIncludeGradleConfigurations
petekanev
commented
Aug 2, 2017
| apply from: it | ||
| } | ||
|
|
||
| def concatenatedDimensions = dimensions.collect { "\"${it}\"" }.join(", "); |
There was a problem hiding this comment.
Apply through flavorDimensions
def (dimensions, includes) = applyPluginIncludeGradles() flavorDimensions(*dimensions)
petekanev
commented
Aug 2, 2017
|
|
||
| apply from: includeFile | ||
|
|
||
| configurationsDir.deleteDir() |
There was a problem hiding this comment.
move to the front of the task
|
💚 |
|
💔 |
|
💚 |
petekanev
force-pushed
the
refactor-include-gradle
branch
from
04cab0e to
1b87953
Compare
|
💚 |
petekanev
changed the title
PanayotCankov
approved these changes
Aug 18, 2017
|
run ci |
|
💔 |
|
run ci |
|
💔 |
|
run ci |
|
💔 |
|
run ci |
|
💔 |
|
run ci |
|
run uitests |
1 similar comment
|
run uitests |
Plamen5kov
approved these changes
Sep 26, 2017
|
run ci |
|
💔 |
petekanev
force-pushed
the
refactor-include-gradle
branch
from
1b87953 to
39b8936
Compare
|
💔 |
1 similar comment
|
💔 |
…ating those copied from the CLI note: this is a temporary workaround, not a permanent solution, as it's not an incremental solution
copy flavor directories that may contain manifests and other resources from node_modules instead of relying on the CLI delete the configurations directory after applying flavors and dimensions
remove redundant runtime gradle project script throw exception if build script is used with a CLI that doesn't produce 'dependencies.json'
make plugin config tasks into functions which are called during gradle's config step
petekanev
force-pushed
the
refactor-include-gradle
branch
from
ed12efc to
86b9d08
Compare
|
💔 |
|
run ci |
|
💔 |
|
run ci |
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradle script creates its own
configurationsdir, it copies the flavors insrcon its own, and configures aar dependencies without having to copy them in the project beforehand.Heavily based off work by @PanayotCankov
Depends on NativeScript/nativescript-cli#3032 first making it into the master branch