Strict file type check for readClasses, fixes #799

[ghost]

Ping @NathanaelA @Pip3r4o #799 (comment)

[ns-bot]

Can one of the admins verify this patch?

[ghost]

run ci

[petekanev]

run ci

[ns-bot]

💔

[petekanev]

@vbresults thanks for your contribution, however the changes do not appear to fix the #799 issue, because although the java execution of the static binding generator won't fail, it won't do much either, since it receives no jar files as input.

Ref: https://github.com/NativeScript/android-runtime/blob/master/android-static-binding-generator/project/build.gradle#L262 - The current list of jar file paths is empty, judging by the build log that @KingAndroid sent us a week ago.

[ghost]

@Pip3r4o Is there a chance that the changes I made are necessary either way, to prevent cli from adding symlinks for example? Also, until the official fix, is there something we can do about the empty current list?

[petekanev]

@vbresults changes in the #798 PR propose major refactoring of the build script, and symlinks should not be a concern. We'll still consider if we should include your changes for overall better code quality and/or readability.

We've not planned or executed on an 'official fix' yet, as we are unable to reproduce the issue reported in #799.

setProperties (https://github.com/NativeScript/android-runtime/blob/master/build-artifacts/project-template-gradle/build.gradle#L727) is the task that collects the jars (https://github.com/NativeScript/android-runtime/blob/master/build-artifacts/project-template-gradle/build.gradle#L589), which are then passed as a list of strings to the static binding generator. I suppose you could copy-paste the logic, although from what I could tell reading the provided build logs, those tasks had passed successfully.

Having said that, I'd appreciate it if you could share information you consider will be relevant to reproducing the problem on my end.