Fix v8 GC Crash caused by incorrect usage of the internal V8 API #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalFieldCount API fix crash after V8 GC was finished when incorrectly using the GetInternalFieldCount failed to resolve the JS Object
|
💚 |
Plamen5kov
reviewed
Aug 9, 2017
|
|
||
| bool ObjectManager::IsJsRuntimeObject(const v8::Local<v8::Object>& object) { | ||
| int internalFieldCount = NativeScriptExtension::GetInternalFieldCount(object); | ||
| int internalFieldCount = object->InternalFieldCount(); |
There was a problem hiding this comment.
well spotted, great job!
Plamen5kov
reviewed
Aug 9, 2017
| /* | ||
| * Deprecated. Use V8 Object.InternalFieldCount() instead. | ||
| * TODO: Pete: remove in following 6.x update | ||
| */ |
There was a problem hiding this comment.
I can almost bet my leg that no one's using it, but just to be safe.
Plamen5kov
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR comprises of:
deprecate V8Extension GetInternalFieldCount and use V8 Object's InternalFieldCount API
fix crash after V8 GC was finished when incorrectly using the GetInternalFieldCount failed to resolve the JS Object
Should address crashes as found and described in nativescript-vue/nativescript-vue#32