Skip to content

Fix v8 GC Crash caused by incorrect usage of the internal V8 API #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Fix v8 GC Crash caused by incorrect usage of the internal V8 API #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/src/main/jni/ObjectManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ ObjectManager::JSInstanceInfo* ObjectManager::GetJSInstanceInfo(const Local<Obje
}

bool ObjectManager::IsJsRuntimeObject(const v8::Local<v8::Object>& object) {
int internalFieldCount = NativeScriptExtension::GetInternalFieldCount(object);
int internalFieldCount = object->InternalFieldCount();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well spotted, great job!

const int count = static_cast<int>(MetadataNodeKeys::END);
return internalFieldCount == count;
}
Expand Down
4 changes: 4 additions & 0 deletions runtime/src/main/jni/include/V8NativeScriptExtension.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ namespace v8 {

static v8::Local<v8::Array> GetPropertyKeys(v8::Isolate *isolate, const v8::Local<v8::Context>& context, const v8::Local<v8::Object>& object, bool& success);

/*
* Deprecated. Use V8 Object.InternalFieldCount() instead.
* TODO: Pete: remove in following 6.x update
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can almost bet my leg that no one's using it, but just to be safe.

static int GetInternalFieldCount(const v8::Local<v8::Object>& object);

static void CpuFeaturesProbe(bool cross_compile);
Expand Down