Update check for android or avdmanager

[vchimev]

No description provided.

[karel1980]

@vchimev The files under scripts/ still use the 'android' command, and as far as I can tell these scripts are super broken, both with the latest 'brew cask install android-sdk' and with the lates android-sdk downloaded from way down at the bottom on https://developer.android.com/studio/index.html

[karel1980]

brew cask install android-sdk downloads https://dl.google.com/android/repository/sdk-tools-darwin-3859397.zip - IDK what version that is supposed to be.

If I use that version then scripts/android-sdk-update spits out a bunch of these:

---

The "android" command is deprecated.
For manual SDK, AVD, and project management, please use Android Studio.
For command-line tools, use tools/bin/sdkmanager and tools/bin/avdmanager

---

/usr/local/share/android-sdk/tools/android: line 115: ${trysdkresponse,,}: bad substitution
Invalid or unsupported command "update sdk --filter extra-google-m2repository --all --no-ui"

Speaking of which, I don't know what that ${foo,,} substitution is supposed to do, that kind of substitution is not in my man page for bash on OSX

[karel1980]

TIL: ${foo,,} is for case substitution, lowercasing the value of ${foo}. Bash on OSX doesn't have this. Had to look into a linux instance

[vchimev]

Hey @karel1980,

Yes, these scripts are obsolete and not in use anymore.

Currently, we use the following scripts for our CI:
https://gist.github.com/vchimev/f134c90aa4d68287c8c0e64d8b901214
https://gist.github.com/vchimev/969b0c495ac3c259eccc77445edb7852

Cheers,
@vchimev

[karel1980]

The scripts are still referenced from the documentation:
https://github.com/NativeScript/functional-tests-core/blob/master/docs/setup.md
Perhaps it's better to include the updated scripts in this repository?

[karel1980]

I don't mind creating the PR. Just let me know

[vchimev]

@karel1980, of course - that would be great! :)