Feat: JSI #186
Merged
Feat: JSI #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammarahm-ed
force-pushed
the
main
branch
2 times, most recently
from
44685d3 to
5a6c2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds JSI runtime to NativeScript iOS runtime. This should enable writing bindings directly with v8 much easier than they are now.
I am expecting most things to work out of the box except ones that have been removed such as https://github.com/facebook/react-native/blob/main/ReactCommon/jsi/jsi/JSIDynamic.cpp which I am pretty sure we won't be needing.
Installing this requires adding some header search paths for which I took the path of using a Podspec for the runtime instead of putting the framework directly: https://github.com/OpenNative/open-native/tree/jsi/pods however adding the headers in the podspec manually in
USER_HEADER_SEARCH_PATHSshould do the job too without the need for a podspec.The podspec: https://github.com/OpenNative/open-native/blob/jsi/pods/NativeScript.podspec