chore(livesync): make livesync method public #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoldonev
reviewed
Jun 19, 2018
|
|
||
| @profile | ||
| private livesync() { | ||
| public livesync() { |
There was a problem hiding this comment.
Should this be public livesync or _livesync?
There was a problem hiding this comment.
Really not sure. @vakrilov what do you think? If it is lower case _livesync no need to document it?
There was a problem hiding this comment.
I think it is better to make it public _livesync() for now
ghost
added
the
vakrilov
previously approved these changes
Jun 25, 2018
ADjenkov
force-pushed
the
djenkov/public-livesync
branch
from
fee8d94 to
a9712e0
Compare
vakrilov
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Livesync method is used in the e2e/modal-navigaiton-ng applicaiton when resetting the root view of the application