Angular 6.1-beta.3 support #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
BREAKING CHANGES: The `document` object is no longer property of the `global` object. This may cause behavioral changes in some plugin that use the `document` object to determine if they're running in browser context. fixes #1144
manoldonev
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged with
rebase and mergeto keep the commit messages.Changes:
fix: provide NullViewportScroller in NativeScriptModule
Required by: angular/angular@49c5234
fix: remove global document object
BREAKING CHANGES:
The
documentobject is no longer property of theglobalobject. Thismay cause behavioral changes in some plugin that use the
documentobject to determine if they're running in browser context.
fixes Global 'document' polyfill causes crashes when used with some node packages #1144
refactor: remove INTERNAL_BROWSER_PROVIDERS from the compiler providers
They rely on the globally attached
documentobject. Also, they're no longer required.related to #1398