refactor(router): Implement page navigation with RouteReuseStrategy (#949)

[vakrilov]

Use RouteReuseStrategy implementation to do page navigation with <page-router-outlet>

[jogboms]

Thanks @vakrilov. This fixed the clearHistory issue. 👍

[jogboms]

JS: ERROR Error: Uncaught (in promise): Error: Currently not in page back navigation - component should be detached instead of deactivated.
JS: Error: Currently not in page back navigation - component should be detached instead of deactivated.
JS:     at PageRouterOutlet.deactivate (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/nativescript-angular/router/page-router-outlet.js:134:19) [angular]
JS:     at ActivateRoutes.deactivateRouteAndOutlet (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4544:32) [angular]
JS:     at ActivateRoutes.deactivateRouteAndItsChildren (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4514:18) [angular]
JS:     at ActivateRoutes.deactivateRoutes (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4500:22) [angular]
JS:     at file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4466:19 [angular]
JS:     at Array.forEach (native) [angular]
JS:     at ActivateRoutes.deactivateChildRoutes (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4464:29) [angular]
JS:     at ActivateRoutes.activate (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4450:14) [angular]
JS:     at file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4064:22 [angular]
JS:     at SafeSubscriber._next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Observable.js:224:21) [angular]
JS:     at SafeSubscriber.__tryOrSetError (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:247:16) [angular]
JS:     at SafeSubscriber.next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:187:27) [angular]
JS:     at Subscriber._next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:125:26) [angular]
JS:     at Subscriber.next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:89:18) [angular]

Any particular reason why i would be getting this for a forward navigation?

    "@angular/router": "^4.2.6",
    "nativescript-angular": "^4.3.0-2017-9-7-3",
    "tns-core-modules": "^3.2.0",

[vakrilov]

There is a problem with the new routing-strategy when using lazy-modules. We will be looking into this in a next few days. Hopefully there will be another patch soon.

[jogboms]

Thanks. Would be looking forward to this.

…

On Sep 11, 2017 9:06 PM, "Alexander Vakrilov" ***@***.***> wrote: There is a problem with the new routing-strategy when using lazy-modules. We will be looking into this in a next few days. Hopefully there will be another patch soon. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#977 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF675nBn23OpbbKep3LCI_E7UodqAGSLks5shZK7gaJpZM4PL4ov> .