feat(tab): migrate template to use BottomNavigation component #79
Conversation
manoldonev
force-pushed
the
mdonev/migrate-to-bottomnav
branch
2 times, most recently
from
96a42a9 to
da54097
Compare
manoldonev
force-pushed
the
mdonev/migrate-to-bottomnav
branch
from
da54097 to
86c3ae6
Compare
manoldonev
force-pushed
the
mdonev/migrate-to-bottomnav
branch
from
bb88098 to
5be380b
Compare
manoldonev
changed the title
manoldonev
changed the title
| *tabItem="{title: 'Home', iconSource: getIconSource('home')}" | ||
| name="homeTab"> | ||
| </page-router-outlet> | ||
| <TabStripItem title="Home" iconSource="font://" /> |
There was a problem hiding this comment.
I don't think we should promote this syntax when you use font icons. It's highly unusual to want the title to be with a font icon font. This syntax is useful when you want to set an image from the resources as an icon source and even then, it's simply a shorthand syntax. The longer more detailed syntax still works.
There was a problem hiding this comment.
I agree, actually thought the same yesterday while explaining pros&cons of each syntax to the team -- forgot to update the comment with app resource value :)
| } | ||
| } | ||
|
|
||
| TabStripItem Label { |
There was a problem hiding this comment.
We can do this whole section with the TabStripItem only since the color property is inherited.
There was a problem hiding this comment.
Actually left it for consistency as platform-specific css needs to set text-transform and (as discussed previously) this is not inherited css property due to historic reasons so we need to use TabStripItem Label { ... } selector there.
manoldonev
force-pushed
the
mdonev/migrate-to-bottomnav
branch
from
c2d20eb to
e6d53ea
Compare
2 participants
No description provided.