-
-
Notifications
You must be signed in to change notification settings - Fork 117
feat(tab): migrate template to use BottomNavigation component #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
86c3ae6
feat(tab-ts): migrate to bottomnavigation
manoldonev cecc1b0
feat(tab-js): migrate to bottomnavigation
manoldonev 5be380b
feat(tab-ng): migrate to bottomnavigation
manoldonev e6d53ea
chore: add comment on TabStripItem declaration
manoldonev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file removed
BIN
-503 Bytes
...e-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-hdpi/browse.png
Binary file not shown.
Binary file removed
BIN
-755 Bytes
...ate-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-hdpi/home.png
Binary file not shown.
Binary file removed
BIN
-924 Bytes
...e-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-hdpi/search.png
Binary file not shown.
Binary file removed
BIN
-452 Bytes
...e-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-mdpi/browse.png
Binary file not shown.
Binary file removed
BIN
-502 Bytes
...ate-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-mdpi/home.png
Binary file not shown.
Binary file removed
BIN
-704 Bytes
...e-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-mdpi/search.png
Binary file not shown.
Binary file removed
BIN
-687 Bytes
...-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-xhdpi/browse.png
Binary file not shown.
Binary file removed
BIN
-1.09 KB
...te-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-xhdpi/home.png
Binary file not shown.
Binary file removed
BIN
-1.38 KB
...-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-xhdpi/search.png
Binary file not shown.
Binary file removed
BIN
-1.12 KB
...tab-navigation-ng/App_Resources/Android/src/main/res/drawable-xxhdpi/browse.png
Binary file not shown.
Binary file removed
BIN
-1.96 KB
...e-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-xxhdpi/home.png
Binary file not shown.
Binary file removed
BIN
-2.51 KB
...tab-navigation-ng/App_Resources/Android/src/main/res/drawable-xxhdpi/search.png
Binary file not shown.
Binary file removed
BIN
-1.61 KB
...ab-navigation-ng/App_Resources/Android/src/main/res/drawable-xxxhdpi/browse.png
Binary file not shown.
Binary file removed
BIN
-3.08 KB
...-tab-navigation-ng/App_Resources/Android/src/main/res/drawable-xxxhdpi/home.png
Binary file not shown.
Binary file removed
BIN
-3.83 KB
...ab-navigation-ng/App_Resources/Android/src/main/res/drawable-xxxhdpi/search.png
Binary file not shown.
Binary file removed
BIN
-441 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/browse.png
Binary file not shown.
Binary file removed
BIN
-754 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/browse@2x.png
Binary file not shown.
Binary file removed
BIN
-929 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/browse@3x.png
Binary file not shown.
Binary file removed
BIN
-383 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/home.png
Binary file not shown.
Binary file removed
BIN
-681 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/home@2x.png
Binary file not shown.
Binary file removed
BIN
-981 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/home@3x.png
Binary file not shown.
Binary file removed
BIN
-391 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/search.png
Binary file not shown.
Binary file removed
BIN
-774 Bytes
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/search@2x.png
Binary file not shown.
Binary file removed
BIN
-1.08 KB
packages/template-tab-navigation-ng/App_Resources/iOS/tabIcons/search@3x.png
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 17 additions & 4 deletions
21
packages/template-tab-navigation-ng/src/app/app.component.android.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,20 @@ | ||
@import 'app.component'; | ||
|
||
// Place any CSS rules you want to apply only on Android here | ||
TabView { | ||
tab-text-color: $blue-dark; | ||
selected-tab-text-color: $item-active-color; | ||
} | ||
TabStripItem Label { | ||
color: $blue-dark; | ||
text-transform: uppercase; | ||
font-weight: bold; | ||
} | ||
|
||
TabStripItem:active Label { | ||
color: $item-active-color; | ||
} | ||
|
||
TabStripItem Image { | ||
color: $blue-dark; | ||
} | ||
|
||
TabStripItem:active Image { | ||
color: $item-active-color; | ||
} |
53 changes: 39 additions & 14 deletions
53
packages/template-tab-navigation-ng/src/app/app.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,43 @@ | ||
<TabView androidTabsPosition="bottom"> | ||
<BottomNavigation> | ||
<TabStrip> | ||
<!-- | ||
Besides the approach demonstrated below there is alternative shorthand syntax for setting TabStripItem title and icon: | ||
|
||
<page-router-outlet | ||
*tabItem="{title: 'Home', iconSource: getIconSource('home')}" | ||
name="homeTab"> | ||
</page-router-outlet> | ||
<TabStripItem title="Home" iconSource="res://tabIcons/home" /> | ||
|
||
<page-router-outlet | ||
*tabItem="{title: 'Browse', iconSource: getIconSource('browse')}" | ||
name="browseTab"> | ||
</page-router-outlet> | ||
Both shorthand and verbose syntax can use | ||
TabStripItem Label {...} css selector to style the title label, | ||
and TabStriptItem Image {...} css selector to style the icon image (see _app-common.scss). | ||
Note that when working with font icons we recommend the usage of the verbose syntax as it | ||
is explicit and describes better the need to provide font icon as well as set the respective font (e.g. via class name). | ||
--> | ||
<TabStripItem> | ||
<!-- | ||
Note TabStripItem will only accept single Label and/or single Image elements that it | ||
will "adopt"; any other layout elements you try to specify will be ignored | ||
--> | ||
<Label text="Home"></Label> | ||
<Image src="font://" class="fa"></Image> | ||
</TabStripItem> | ||
<TabStripItem> | ||
<Label text="Browse"></Label> | ||
<Image src="font://" class="fa"></Image> | ||
</TabStripItem> | ||
<TabStripItem> | ||
<Label text="Search"></Label> | ||
<Image src="font://" class="fa"></Image> | ||
</TabStripItem> | ||
</TabStrip> | ||
|
||
<page-router-outlet | ||
*tabItem="{title: 'Search', iconSource: getIconSource('search')}" | ||
name="searchTab"> | ||
</page-router-outlet> | ||
<TabContentItem> | ||
<page-router-outlet name="homeTab"></page-router-outlet> | ||
</TabContentItem> | ||
|
||
</TabView> | ||
<TabContentItem> | ||
<page-router-outlet name="browseTab"></page-router-outlet> | ||
</TabContentItem> | ||
|
||
<TabContentItem> | ||
<page-router-outlet name="searchTab"></page-router-outlet> | ||
</TabContentItem> | ||
</BottomNavigation> |
18 changes: 15 additions & 3 deletions
18
packages/template-tab-navigation-ng/src/app/app.component.ios.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,18 @@ | ||
@import 'app.component'; | ||
|
||
// Place any CSS rules you want to apply only on IOS here | ||
TabView { | ||
selected-tab-text-color: $item-active-color; | ||
} | ||
TabStripItem Label { | ||
color: $blue-dark; | ||
} | ||
|
||
TabStripItem:active Label { | ||
color: $item-active-color; | ||
} | ||
|
||
TabStripItem Image { | ||
color: $blue-dark; | ||
} | ||
|
||
TabStripItem:active Image { | ||
color: $item-active-color; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-503 Bytes
...b-navigation-ts/app/App_Resources/Android/src/main/res/drawable-hdpi/browse.png
Binary file not shown.
Binary file removed
BIN
-755 Bytes
...tab-navigation-ts/app/App_Resources/Android/src/main/res/drawable-hdpi/home.png
Diff not rendered.
Binary file removed
BIN
-924 Bytes
...b-navigation-ts/app/App_Resources/Android/src/main/res/drawable-hdpi/search.png
Diff not rendered.
Binary file removed
BIN
-452 Bytes
...b-navigation-ts/app/App_Resources/Android/src/main/res/drawable-mdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-502 Bytes
...tab-navigation-ts/app/App_Resources/Android/src/main/res/drawable-mdpi/home.png
Diff not rendered.
Binary file removed
BIN
-704 Bytes
...b-navigation-ts/app/App_Resources/Android/src/main/res/drawable-mdpi/search.png
Diff not rendered.
Binary file removed
BIN
-687 Bytes
...-navigation-ts/app/App_Resources/Android/src/main/res/drawable-xhdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-1.09 KB
...ab-navigation-ts/app/App_Resources/Android/src/main/res/drawable-xhdpi/home.png
Diff not rendered.
Binary file removed
BIN
-1.38 KB
...-navigation-ts/app/App_Resources/Android/src/main/res/drawable-xhdpi/search.png
Diff not rendered.
Binary file removed
BIN
-1.12 KB
...navigation-ts/app/App_Resources/Android/src/main/res/drawable-xxhdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-1.96 KB
...b-navigation-ts/app/App_Resources/Android/src/main/res/drawable-xxhdpi/home.png
Diff not rendered.
Binary file removed
BIN
-2.51 KB
...navigation-ts/app/App_Resources/Android/src/main/res/drawable-xxhdpi/search.png
Diff not rendered.
Binary file removed
BIN
-1.61 KB
...avigation-ts/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-3.08 KB
...-navigation-ts/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/home.png
Diff not rendered.
Binary file removed
BIN
-3.83 KB
...avigation-ts/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/search.png
Diff not rendered.
Binary file removed
BIN
-441 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/browse.png
Diff not rendered.
Binary file removed
BIN
-754 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/browse@2x.png
Diff not rendered.
Binary file removed
BIN
-929 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/browse@3x.png
Diff not rendered.
Binary file removed
BIN
-383 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/home.png
Diff not rendered.
Binary file removed
BIN
-681 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/home@2x.png
Diff not rendered.
Binary file removed
BIN
-981 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/home@3x.png
Diff not rendered.
Binary file removed
BIN
-391 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/search.png
Diff not rendered.
Binary file removed
BIN
-774 Bytes
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/search@2x.png
Diff not rendered.
Binary file removed
BIN
-1.08 KB
packages/template-tab-navigation-ts/app/App_Resources/iOS/tabIcons/search@3x.png
Diff not rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,51 @@ | ||
<!-- | ||
The TabView component provides a simple way to navigate between different views by | ||
tapping on some of the tabs or by swiping between the views. | ||
Learn more about the TabView component in this documentation article: | ||
http://docs.nativescript.org/cookbook/ui/tab-view | ||
The BottomNavigation component provides a way for high level navigation between different views by | ||
tapping on some of the tabs. Learn more about the BottomNavigation component | ||
in this documentation article: https://docs.nativescript.org/ui/ns-ui-widgets/bottom-navigation. | ||
Tabs component is similar to BottomNavigation but suitable for mid level navigation scenarios thus | ||
supports swiping between the views. Learn more about the Tabs component in this documentation article: | ||
https://docs.nativescript.org/angular/ui/ng-ui-widgets/tabs. | ||
--> | ||
<TabView androidTabsPosition="bottom"> | ||
<TabViewItem title="Home" ios:iconSource="res://tabIcons/home" android:iconSource="res://home"> | ||
<Frame defaultPage="home/home-items-page"></Frame> | ||
</TabViewItem> | ||
<BottomNavigation> | ||
<TabStrip> | ||
<!-- | ||
Besides the approach demonstrated below there is alternative shorthand syntax for setting TabStripItem title and icon: | ||
|
||
<TabViewItem title="Browse" ios:iconSource="res://tabIcons/browse" android:iconSource="res://browse"> | ||
<Frame defaultPage="browse/browse-page"></Frame> | ||
</TabViewItem> | ||
<TabStripItem title="Home" iconSource="res://tabIcons/home" /> | ||
|
||
<TabViewItem title="Search" ios:iconSource="res://tabIcons/search" android:iconSource="res://search"> | ||
<Frame defaultPage="search/search-page"></Frame> | ||
</TabViewItem> | ||
</TabView> | ||
Both shorthand and verbose syntax can use | ||
TabStripItem Label {...} css selector to style the title label, | ||
and TabStriptItem Image {...} css selector to style the icon image (see _app-common.scss). | ||
Note that when working with font icons we recommend the usage of the verbose syntax as it | ||
is explicit and describes better the need to provide font icon as well as set the respective font (e.g. via class name). | ||
--> | ||
<TabStripItem> | ||
<!-- | ||
Note TabStripItem will only accept single Label and/or single Image elements that it | ||
will "adopt"; any other layout elements you try to specify will be ignored | ||
--> | ||
<Label text="Home" /> | ||
<Image src="font://" class="fa" /> | ||
</TabStripItem> | ||
<TabStripItem> | ||
<Label text="Browse" /> | ||
<Image src="font://" class="fa" /> | ||
</TabStripItem> | ||
<TabStripItem> | ||
<Label text="Search" /> | ||
<Image src="font://" class="fa" /> | ||
</TabStripItem> | ||
</TabStrip> | ||
|
||
<TabContentItem> | ||
<Frame defaultPage="home/home-items-page" /> | ||
</TabContentItem> | ||
|
||
<TabContentItem> | ||
<Frame defaultPage="browse/browse-page" /> | ||
</TabContentItem> | ||
|
||
<TabContentItem> | ||
<Frame defaultPage="search/search-page" /> | ||
</TabContentItem> | ||
</BottomNavigation> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-503 Bytes
...-tab-navigation/app/App_Resources/Android/src/main/res/drawable-hdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-755 Bytes
...te-tab-navigation/app/App_Resources/Android/src/main/res/drawable-hdpi/home.png
Diff not rendered.
Binary file removed
BIN
-924 Bytes
...-tab-navigation/app/App_Resources/Android/src/main/res/drawable-hdpi/search.png
Diff not rendered.
Binary file removed
BIN
-452 Bytes
...-tab-navigation/app/App_Resources/Android/src/main/res/drawable-mdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-502 Bytes
...te-tab-navigation/app/App_Resources/Android/src/main/res/drawable-mdpi/home.png
Diff not rendered.
Binary file removed
BIN
-704 Bytes
...-tab-navigation/app/App_Resources/Android/src/main/res/drawable-mdpi/search.png
Diff not rendered.
Binary file removed
BIN
-687 Bytes
...tab-navigation/app/App_Resources/Android/src/main/res/drawable-xhdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-1.09 KB
...e-tab-navigation/app/App_Resources/Android/src/main/res/drawable-xhdpi/home.png
Diff not rendered.
Binary file removed
BIN
-1.38 KB
...tab-navigation/app/App_Resources/Android/src/main/res/drawable-xhdpi/search.png
Diff not rendered.
Binary file removed
BIN
-1.12 KB
...ab-navigation/app/App_Resources/Android/src/main/res/drawable-xxhdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-1.96 KB
...-tab-navigation/app/App_Resources/Android/src/main/res/drawable-xxhdpi/home.png
Diff not rendered.
Binary file removed
BIN
-2.51 KB
...ab-navigation/app/App_Resources/Android/src/main/res/drawable-xxhdpi/search.png
Diff not rendered.
Binary file removed
BIN
-1.61 KB
...b-navigation/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/browse.png
Diff not rendered.
Binary file removed
BIN
-3.08 KB
...tab-navigation/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/home.png
Diff not rendered.
Binary file removed
BIN
-3.83 KB
...b-navigation/app/App_Resources/Android/src/main/res/drawable-xxxhdpi/search.png
Diff not rendered.
Binary file removed
BIN
-441 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/browse.png
Diff not rendered.
Binary file removed
BIN
-754 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/browse@2x.png
Diff not rendered.
Binary file removed
BIN
-929 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/browse@3x.png
Diff not rendered.
Binary file removed
BIN
-383 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/home.png
Diff not rendered.
Binary file removed
BIN
-681 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/home@2x.png
Diff not rendered.
Binary file removed
BIN
-981 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/home@3x.png
Diff not rendered.
Binary file removed
BIN
-391 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/search.png
Diff not rendered.
Binary file removed
BIN
-774 Bytes
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/search@2x.png
Diff not rendered.
Binary file removed
BIN
-1.08 KB
packages/template-tab-navigation/app/App_Resources/iOS/tabIcons/search@3x.png
Diff not rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,51 @@ | ||
<!-- | ||
The TabView component provides a simple way to navigate between different views by | ||
tapping on some of the tabs or by swiping between the views. | ||
Learn more about the TabView component in this documentation article: | ||
http://docs.nativescript.org/cookbook/ui/tab-view | ||
The BottomNavigation component provides a way for high level navigation between different views by | ||
tapping on some of the tabs. Learn more about the BottomNavigation component | ||
in this documentation article: https://docs.nativescript.org/ui/ns-ui-widgets/bottom-navigation. | ||
Tabs component is similar to BottomNavigation but suitable for mid level navigation scenarios thus | ||
supports swiping between the views. Learn more about the Tabs component in this documentation article: | ||
https://docs.nativescript.org/angular/ui/ng-ui-widgets/tabs. | ||
--> | ||
<TabView androidTabsPosition="bottom"> | ||
<TabViewItem title="Home" ios:iconSource="res://tabIcons/home" android:iconSource="res://home"> | ||
<Frame defaultPage="home/home-items-page"></Frame> | ||
</TabViewItem> | ||
<BottomNavigation> | ||
<TabStrip> | ||
<!-- | ||
Besides the approach demonstrated below there is alternative shorthand syntax for setting TabStripItem title and icon: | ||
|
||
<TabViewItem title="Browse" ios:iconSource="res://tabIcons/browse" android:iconSource="res://browse"> | ||
<Frame defaultPage="browse/browse-page"></Frame> | ||
</TabViewItem> | ||
<TabStripItem title="Home" iconSource="res://tabIcons/home" /> | ||
|
||
<TabViewItem title="Search" ios:iconSource="res://tabIcons/search" android:iconSource="res://search"> | ||
<Frame defaultPage="search/search-page"></Frame> | ||
</TabViewItem> | ||
</TabView> | ||
Both shorthand and verbose syntax can use | ||
TabStripItem Label {...} css selector to style the title label, | ||
and TabStriptItem Image {...} css selector to style the icon image (see _app-common.scss). | ||
Note that when working with font icons we recommend the usage of the verbose syntax as it | ||
is explicit and describes better the need to provide font icon as well as set the respective font (e.g. via class name). | ||
--> | ||
<TabStripItem> | ||
<!-- | ||
Note TabStripItem will only accept single Label and/or single Image elements that it | ||
will "adopt"; any other layout elements you try to specify will be ignored | ||
--> | ||
<Label text="Home" /> | ||
<Image src="font://" class="fa" /> | ||
</TabStripItem> | ||
<TabStripItem> | ||
<Label text="Browse" /> | ||
<Image src="font://" class="fa" /> | ||
</TabStripItem> | ||
<TabStripItem> | ||
<Label text="Search" /> | ||
<Image src="font://" class="fa" /> | ||
</TabStripItem> | ||
</TabStrip> | ||
|
||
<TabContentItem> | ||
<Frame defaultPage="home/home-items-page" /> | ||
</TabContentItem> | ||
|
||
<TabContentItem> | ||
<Frame defaultPage="browse/browse-page" /> | ||
</TabContentItem> | ||
|
||
<TabContentItem> | ||
<Frame defaultPage="search/search-page" /> | ||
</TabContentItem> | ||
</BottomNavigation> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do this whole section with the
TabStripItem
only since thecolor
property is inherited.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually left it for consistency as platform-specific css needs to set
text-transform
and (as discussed previously) this is not inherited css property due to historic reasons so we need to use TabStripItem Label { ... } selector there.