LiveSync support #628
Merged
LiveSync support #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| ///<reference path="../.d.ts"/> | ||
| "use strict"; | ||
|
|
||
| export class UsbLivesyncCommand implements ICommand { |
There was a problem hiding this comment.
There is no need to prefix this with Usb. Both iOS and Android support this over the air.
|
✅ |
1 similar comment
|
✅ |
| } | ||
|
|
||
| public get deviceProjectRootPath(): string { | ||
| return `/data/local/tmp/12590FAA-5EDD-4B12-856D-F52A0A1599F2/${this.appIdentifier}`; |
There was a problem hiding this comment.
is this expected identifier 12590FAA-5EDD-4...
There was a problem hiding this comment.
Probably it a good idea to give this path a named constant to explain why it is such.
| @@ -5,7 +5,7 @@ | |||
| "configurations": [ | |||
| { | |||
| // Name of configuration; appears in the launch configuration drop down menu. | |||
| "name": "build", | |||
| "name": "livesync", | |||
There was a problem hiding this comment.
Can we .gitignore this file, please?
There was a problem hiding this comment.
👍 , only basic setup of the file is required, which is already done, all other changes must be gitignored
|
❌ |
|
✅ |
|
|
||
| public canExecute(args: string[]): IFuture<boolean> { | ||
| return (() => { | ||
| let platform = args[0]; |
There was a problem hiding this comment.
This way the command will work no matter of the number of arguments passed, for example
tns livesync android goshko ios peshko john
|
✅ |
|
👍 |
|
✅ |
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after this PR telerik/mobile-cli-lib#376