Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using this lib results in iOS App Store rejection issue - related to `node-sass` dependency #3

Closed
NathanWalker opened this issue Jul 7, 2016 · 9 comments

Comments

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Jul 7, 2016

I'm not sure how to solve this just yet, but I ran into this tonight while trying to upload an app to the iOS App Store:

ERROR ITMS-90171: "Invalid Bundle Structure - The binary file 'ShoutOutPlay.app/app/tns_modules/node-sass/vendor/darwin-x64-47/binding.node' is not permitted. Your app can’t contain standalone executables or libraries, other than the CFBundleExecutable of supported bundles. Refer to the Bundle Programming Guide at https://developer.apple.com/go/?id=bundle-structure for information on the iOS app bundle structure."
ERROR ITMS-90171: "Invalid Bundle Structure - The binary file 'ShoutOutPlay.app/app/tns_modules/node-sass/vendor/darwin-x64-47/binding.node' is not permitted. Your app can’t contain standalone executables or libraries, other than the CFBundleExecutable of supported bundles. Refer to the Bundle Programming Guide at https://developer.apple.com/go/?id=bundle-structure for information on the iOS app bundle structure."

ERROR ITMS-90512: "Invalid sdk value. The value provided for the sdk portion of LC_VERSION_MIN_MACOSX in ShoutOutPlay.app/app/tns_modules/node-sass/vendor/darwin-x64-47/binding.node is 10.11 which is greater than the maximum allowed value of 10.0."
ERROR ITMS-90512: "Invalid sdk value. The value provided for the sdk portion of LC_VERSION_MIN_MACOSX in ShoutOutPlay.app/app/tns_modules/node-sass/vendor/darwin-x64-47/binding.node is 10.11 which is greater than the maximum allowed value of 10.0."

Going into the archive and manually removing the node-sass/vendor folder allows the app store submittal to proceed. If a solution comes to mind to fix here, I'll submit a PR, not sure.

@toddanglin

This comment has been minimized.

Copy link
Contributor

@toddanglin toddanglin commented Jul 9, 2016

Interesting. I wonder if any of NativeScript's build step hooks could be used to remove this folder? Not sure how to solve either, but will think about it, too. Thanks for reporting the issue!

@NathanWalker

This comment has been minimized.

Copy link
Contributor Author

@NathanWalker NathanWalker commented Aug 9, 2016

Using a webpack build does get away from this issue so I'm going to close this for now. Since using the webpack plugin to create production builds for deployment across the stores should be the standard.

@toddanglin

This comment has been minimized.

Copy link
Contributor

@toddanglin toddanglin commented Aug 17, 2016

I'm sure it could benefit others to see what you're doing with webpack, both to resolve this issue and generally improve production builds. If you end-up blogging about it, feel free to share a link here. Probably good fodder for improving the README for this plugin, too.

@dotdreaming

This comment has been minimized.

Copy link

@dotdreaming dotdreaming commented Oct 27, 2016

Hi guys, I have the same error. How do you use webpack in the build to get round this?

@toddanglin

This comment has been minimized.

Copy link
Contributor

@toddanglin toddanglin commented Oct 27, 2016

Now that there is a post-build step in this plugin, I think we could add an additional action to auto-remove this node-sass folder. I don't think there is any reason to include it in the final build output. Let me take a fresh look.

@toddanglin toddanglin reopened this Oct 27, 2016
@dotdreaming

This comment has been minimized.

Copy link

@dotdreaming dotdreaming commented Oct 27, 2016

That would be awesome

@NathanWalker

This comment has been minimized.

Copy link
Contributor Author

@NathanWalker NathanWalker commented Oct 27, 2016

@dotdreaming @toddanglin this works really well too if you run into webpack struggles:
https://www.npmjs.com/package/nativescript-hook-filter-modules
Works really well. 👍

@toddanglin

This comment has been minimized.

Copy link
Contributor

@toddanglin toddanglin commented Oct 27, 2016

Okay. The fix is in and the plugin is version bumped to 0.4.1. The node-sass directory will now be auto-deleted. Nathan's suggestion is great, too, for cleaning-up other unneeded runtime modules.

@dotdreaming

This comment has been minimized.

Copy link

@dotdreaming dotdreaming commented Oct 27, 2016

Excellent.
I used hook-filter-modules and it worked a treat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.