CompositeException stops mutating nested Exceptions #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks, but instead aggregates them at print-time. Since nothing is being mutated, there's no chance of accidentally creating a cycle in the Exception chain.
|
RxJava-pull-requests #1329 FAILURE |
|
RxJava-pull-requests #1330 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Jun 25, 2014
…n-creation CompositeException stops mutating nested Exceptions
|
|
||
| ex.printStackTrace(); | ||
| //ex.printStackTrace(printStream); | ||
| //assertFalse(baos.toString().contains("CIRCULAR REFERENCE")); |
There was a problem hiding this comment.
The assertion is commented out. Does this actually test anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, it aggregates them at print-time. Since nothing is being mutated, there's no chance of accidentally creating a cycle in the Exception chain. We ran into this in production very intermittently and had to add handling any time we were touching the Exception chain.