Feature/google drive to folders #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevgliss
force-pushed
the
feature/google-drive-to-folders
branch
from
fdb8247
to
075988a
Compare
mvilanova
previously requested changes
Apr 13, 2020
Co-Authored-By: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-Authored-By: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-Authored-By: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-Authored-By: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
|
This PR is blocked until the sharing of drive folders reaches GA. |
|
Stale pull request message |
|
This pull request introduces 2 alerts and fixes 5 when merging b079fab into 070587e - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves us off google shared drives in favor of using folders instead.
This has a couple of advantages:
Additionally, we don't have to control the individual sharing permissions of every drive, instead of letting the top-level folder or top-level shared drive control general sharing permissions.
This PR also adds two envvars and deprecates two others:
Adds:
INCIDENT_STORAGE_FOLDER_ID: Top level folder where all incident data is stored. Note: viewing actual incident data is still on a per-sub folder basis.INCIDENT_STORAGE_OPEN_ON_CLOSE: After an incident is closed we as an organization try to be transparent and allow others to view incident data. This is not desirable in all organizations. The default isTrueor to open after close.Deprecates:
INCIDENT_STORAGE_ARCHIVAL_FOLDER_ID: Is no longer needed, due to the fact that we won't me moving files for archival.INCIDENT_STORAGE_RESTRICTED: Is no longer needed because we use whatever top-level permissions are for the folder or shared drive (instead of setting it for each not team drive).