Eip778 #3701
Merged
Eip778 #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dceleda
reviewed
Dec 18, 2021
| protected abstract int GetRlpLengthOfValue(); | ||
|
|
||
| /// <summary> | ||
| /// Gets the key as a string to be added in the |
| public class NodeRecord | ||
| { | ||
| private SortedDictionary<string, EnrContentEntry> Entries { get; } = new(); | ||
|
|
There was a problem hiding this comment.
Property desc?
The sequence number, a 64-bit unsigned integer. Nodes should increase the number whenever the record changes and republish the record.
| { | ||
| private SortedDictionary<string, EnrContentEntry> Entries { get; } = new(); | ||
|
|
||
| public int Sequence { get; set; } |
There was a problem hiding this comment.
Maybe worth renaming to Seq ? Or maybe EnrSequence ?
dceleda
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2618
Changes:
Implements EIP-778
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??