Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rpc rpc modules #4177

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Add Rpc rpc modules #4177

merged 4 commits into from
Jun 22, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 21, 2022

Closes #3972

Replicate geth's rpc_modules command. so that geth attach would work.

Changes:

  • Add RpcRpcModule.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

  • Call method, got
{'jsonrpc': '2.0', 'result': {'eth': '1.0', 'proof': '1.0', 'debug': '1.0', 'trace': '1.0', 'personal': '1.0', 'txPool': '1.0', 'net': '1.0', 'parity': '1.0', 'subscribe': '1.0', 'web3': '1.0'}, 'id': 12}
  • Specify ipc port to ~/.ethereum/geth.ipc, run get attach, call eth.getBlockByNumber(1), seems to return a block.

Further comments (optional)

Rpc module is not turned on by default on most config.

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove config changes and submodule changes, otherwise we can merge

@@ -200,7 +200,10 @@
},
"Ropsten Archive": {
"commandName": "Project",
"commandLineArgs": "--config configs\\ropsten_archive.cfg --baseDbPath C:\\nethermind_db"
"commandLineArgs": "--config configs\\ropsten_archive.cfg --baseDbPath C:\\nethermind_db",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove changes

src/Nethermind/Nethermind.Runner/configs/kiln.cfg Outdated Show resolved Hide resolved
@asdacap asdacap force-pushed the fix/geth-attach-not-working branch from d676741 to 84f0a65 Compare June 22, 2022 08:24
@LukaszRozmej LukaszRozmej merged commit 2500d3d into master Jun 22, 2022
@LukaszRozmej LukaszRozmej deleted the fix/geth-attach-not-working branch June 22, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rpc_modules not supported for geth attach command
2 participants