Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fcu peer refresher #4217

Merged
merged 11 commits into from
Jul 4, 2022
Merged

Fcu peer refresher #4217

merged 11 commits into from
Jul 4, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 28, 2022

  • Update peer refreshing to use FCU's hashes.

Changes:

  • Update peer refreshing to use FCU's hashes. It will now only disconnect if the finalized block is not available from the peer.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

  • Ropsten can sync to head.

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After review from Łukasz I suggest running nodes with tracing for refreshing in order to observe how the node is behaving. Generally PR is looking good I proposed a few changes

@LukaszRozmej
Copy link
Member

Still few thing unaddressed.

@LukaszRozmej LukaszRozmej merged commit 394f330 into master Jul 4, 2022
@LukaszRozmej LukaszRozmej deleted the fcu-peer-refresher branch July 4, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants