Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix probably cause of trie exception #4285

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jul 17, 2022

Fixes #4275

Fix TrieException due to pruning when a lower block produce sami storage root as newer block which causes it's LastSeen number to be reduced which will cause it to be memory pruned as no longer needed.

Changes:

  • Ensure LastSeen does not get reduced

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@asdacap asdacap requested a review from MarekM25 July 17, 2022 09:06
@MarekM25 MarekM25 merged commit e31cbbb into master Jul 17, 2022
@MarekM25 MarekM25 deleted the fix-trie-exception-due-to-reduced-lastseen branch July 17, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrieException in BlockProcessor
2 participants