Engine url parameters #4358
Merged
Engine url parameters #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Aug 3, 2022
MarekM25
reviewed
Aug 3, 2022
| @@ -32,7 +32,7 @@ public JsonRpcUrl(string scheme, string host, int port, RpcEndpoint rpcEndpoint, | |||
| Host = host; | |||
| Port = port; | |||
| RpcEndpoint = rpcEndpoint; | |||
| EnabledModules = enabledModules; | |||
| EnabledModules = enabledModules.Select(name => name.ToLower()).ToArray(); | |||
There was a problem hiding this comment.
could you explain why we're changing it?
There was a problem hiding this comment.
In some plases we check that "engine"(in lower case) module in this list. I thought it might cause similar problems in the future, so a better solution is to change it here
There was a problem hiding this comment.
Wouldn't it be better then to do: EnabledModules = new HashSet<string>(enabledModules, StringComparer.InvariantCultureIgnoreCase)
MarekM25
reviewed
Aug 5, 2022
| return; | ||
| } | ||
| JsonRpcUrl url = new(Uri.UriSchemeHttp, _jsonRpcConfig.EngineHost, _jsonRpcConfig.EnginePort.Value, | ||
| RpcEndpoint.Http, true, _jsonRpcConfig.EngineEnabledModules.Append("engine").ToArray()); |
There was a problem hiding this comment.
Minor: using string "engine" could be painful in case of refacotring
MarekM25
reviewed
Aug 5, 2022
|
|
||
| public static IEnumerable<string> DefaultEngineModules { get; } = new List<string>() | ||
| { | ||
| Net, |
MarekM25
reviewed
Aug 5, 2022
| @@ -2,14 +2,16 @@ | |||
| "Init": { | |||
| "IsMining": true, | |||
| "WebSocketsEnabled": true, | |||
| "ChainSpecPath": "chainspec/catalyst.json", | |||
| "ChainSpecPath": "chainspec/catalyst.json", | |||
MarekM25
reviewed
Aug 5, 2022
| @@ -20,8 +20,7 @@ | |||
| "Timeout": 20000, | |||
| "Host": "127.0.0.1", | |||
| "Port": 8545, | |||
| "EnabledModules": ["Eth", "Subscribe", "Trace", "TxPool", "Web3", "Personal", "Proof", "Net", "Parity", "Health", "Debug"], | |||
MarekM25
reviewed
Aug 5, 2022
| @@ -28,8 +28,7 @@ | |||
| "Timeout": 20000, | |||
| "Host": "127.0.0.1", | |||
| "Port": 8545, | |||
| "EnabledModules": ["Eth", "Subscribe", "Trace", "TxPool", "Web3", "Personal", "Proof", "Net", "Parity", "Health", "Debug"], | |||
| "AdditionalRpcUrls": ["http://localhost:8551|http;ws|net;eth;subscribe;engine;web3;client"] | |||
smartprogrammer93
approved these changes
Aug 8, 2022
MarekM25
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
I've changed configuration files. It may cause problems