Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TryGetPendingTransaction #4383

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Fix TryGetPendingTransaction #4383

merged 4 commits into from
Aug 8, 2022

Conversation

marcindsobczak
Copy link
Contributor

Changes:

  • TryGetPendingTransaction will look for TxHash in persistentTxs in TxBroadcaster before returning false

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

persistent tx

@LukaszRozmej LukaszRozmej merged commit e4c0529 into master Aug 8, 2022
@LukaszRozmej LukaszRozmej deleted the fix_TryGetPendingTx branch August 8, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcindsobczak @LukaszRozmej