Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable WitnessProtocol from default configs #4447

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

LukaszRozmej
Copy link
Member

Resolves #4443

Changes:

  • Disable WitnessProtocol from default configs, this is due to Besu cannot parse our Hello message and cannot connect to us (issue on Besu side)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): config change

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 36633bc into master Aug 19, 2022
@LukaszRozmej LukaszRozmej deleted the disable-witness-protocol-from-defaults branch August 19, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nethermind hello message reports wrong version for witness protocol
2 participants