Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when using larger than default pruning cache #7066

Merged
merged 1 commit into from
May 23, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented May 23, 2024

  • Warn when using pruning cache larger than 2GB as the pruning hang can take large amount of time which effect attestation.
  • Large pruning cache was mainly used to reduce database growth, but since Ahmad's node running 1GB pruning cache for the past 3 month only grow by 25GB, its probably fine to keep the default for most user.
  • One scenario where it still make sense is for RPC provider as more cache does improve block processing performance or when setting much longer pruning boundary where large prune cache is unavoidable. For reference, on mainnet minimum prune cache size is about 450MB for past 128 state to support snap serving.

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Tested with setting and not setting te config.

@asdacap asdacap merged commit 44d31c1 into master May 23, 2024
68 checks passed
@asdacap asdacap deleted the log/warn-when-using-large-pruning-cache branch May 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants