Skip to content

Conversation

apdavison
Copy link
Member

This follows the discussion in #210. Since individual RecordingChannel objects have been removed from the proposed Neo 0.4 API, the name RecordingChannelGroup no longer seems appropriate.

@samuelgarcia
Copy link
Contributor

Hi andrew.

OK for this.

The only litlle comment I could do is that we lost here the semantic of Group.
Maybe this not important.

A typical use case even if noby use I guess is:
We have 128 channels that come from 2 diffrents arrays of 64 electrodes in the same recording.

signals = neo.AnalogSignal(np.zeros(nb_sample, 128), units='uV', sampling_rate=10*pq.kHz)
indexes_A = neo.ChannelIndex(name='shank A', channel_indexes=np.arange(0,64))
indexes_B = neo.ChannelIndex(name='shank B', channel_indexes=np.arange(64,128))

Maybe the semantic of ChannelGroup is easier to catch. I do known.

This is just to have your opinion on that I don't care so much.
So OK for me for merge.

Thank again for all the work in apibreak.

@coveralls
Copy link

coveralls commented Jun 22, 2016

Coverage Status

Coverage decreased (-0.02%) to 57.452% when pulling 3dcc9da on apdavison:channelindex into 066777b on NeuralEnsemble:apibreak.

@coveralls
Copy link

coveralls commented Jun 22, 2016

Coverage Status

Coverage decreased (-0.04%) to 57.431% when pulling b4e7be6 on apdavison:channelindex into 066777b on NeuralEnsemble:apibreak.

@apdavison apdavison merged commit b4e7be6 into NeuralEnsemble:apibreak Jun 22, 2016
@apdavison apdavison deleted the channelindex branch July 7, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants