Skip to content

Updating check for NoneType by using "is" instead of "==" #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2016
Merged

Updating check for NoneType by using "is" instead of "==" #246

merged 1 commit into from
Jun 23, 2016

Conversation

JuliaSprenger
Copy link
Member

Minor fix by substituting "==" by "is" for comparison to None.
Using "== None" currently results in a warning: "FutureWarning: comparison to None will result in an elementwise object comparison in the future."

@coveralls
Copy link

coveralls commented Jun 23, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 57.424% when pulling ad3c7ef on INM-6:fix/nonetype_check into 7bffea0 on NeuralEnsemble:apibreak.

@apdavison apdavison merged commit 35d82c2 into NeuralEnsemble:apibreak Jun 23, 2016
@JuliaSprenger JuliaSprenger deleted the fix/nonetype_check branch June 24, 2016 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaSprenger @coveralls @apdavison