Skip to content

Conversation

hkchekc
Copy link
Contributor

@hkchekc hkchekc commented Oct 19, 2018

in Reference to Issue #575 , some basic test for nixio_fr and compatability test of nixio and nixio_fr is added.

@pep8speaks
Copy link

pep8speaks commented Oct 19, 2018

Hello @hkchekc! Thanks for updating the PR.

Comment last updated on December 06, 2018 at 15:58 Hours UTC

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.09%) to 48.592% when pulling 482a208 on hkchekc:master into c8727e1 on NeuralEnsemble:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.09%) to 48.592% when pulling 482a208 on hkchekc:master into c8727e1 on NeuralEnsemble:master.

@coveralls
Copy link

coveralls commented Oct 19, 2018

Coverage Status

Coverage decreased (-0.05%) to 49.591% when pulling edfe891 on hkchekc:master into 043e480 on NeuralEnsemble:master.

@JuliaSprenger
Copy link
Member

Hi @hkchekc! Thanks for adding some more tests!
Currently the new tests are failing because of an incomplete path to the test files. You can get the correct path by using self.get_filename_path(filename).

@JuliaSprenger
Copy link
Member

And you need to inherit from BaseTestIO to have this function available. You can compare to https://github.com/NeuralEnsemble/python-neo/blob/master/neo/test/iotest/test_blackrockio.py as an example implementation.

@apdavison apdavison added the IO label Oct 22, 2018
@hkchekc
Copy link
Contributor Author

hkchekc commented Oct 22, 2018

One test will fail now due to a bug which will be fixed in the PR #581
This is merged.

@apdavison apdavison added this to the 0.7.0 milestone Nov 15, 2018
@JuliaSprenger
Copy link
Member

@hkchekc: You will also need to adjust the conversion of nix attributes to regular python objects, because nix objects are not supported by neo eg. as annotations.

@samuelgarcia samuelgarcia modified the milestones: 0.7.0, 0.8.0 Nov 26, 2018
@hkchekc
Copy link
Contributor Author

hkchekc commented Dec 6, 2018

We upload a new nix file for test on Gin.

@JuliaSprenger
Copy link
Member

I merged the new file and rerun the tests. However, they are still failing somewhere within nix when parsing the header. Do you have an idea how to fix this?

@JuliaSprenger
Copy link
Member

@hkchekc: Thanks for fixing the CI tests.
I still get an error when running the tests locally with numpy 1.15.1 and nixio 1.5.0b2

Failure
  File .../python-neo/neo/rawio/tests/common_rawio_test.py", line 151, in test_read_all
    compliance.read_analogsignals(reader)
  File ".../python-neo/neo/rawio/tests/rawio_compliance.py", line 144, in read_analogsignals
    assert raw_chunk.ndim == 2
AssertionError

It seems that raw_chunk.ndim ==1 in at least one case here. Do you have an idea why this might be the case?

@hkchekc
Copy link
Contributor Author

hkchekc commented Dec 7, 2018

@JuliaSprenger I try to use numpy 1.15.1 and nixio 1.5.0b2 to run the test_nixio_fr.py and test_nixrawio.py for both 'nixrawio-1.5.nix' and ' nixio_fr.nix' and could not reproduce the error.

Can you tell me more details?

I used Python3.5 and 3.7

@JuliaSprenger
Copy link
Member

Hi @hkchekc,
I had a closer look and think that the error was somehow related to an improper setup of my environment. If I create a new environment everything works smoothly. Sorry for the confusion.
I will merge this now.

@JuliaSprenger JuliaSprenger merged commit 3abdb73 into NeuralEnsemble:master Dec 10, 2018
@hkchekc
Copy link
Contributor Author

hkchekc commented Dec 10, 2018

Thanks for all the checkings! @JuliaSprenger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants