-
Notifications
You must be signed in to change notification settings - Fork 261
create basic and compatability test for nixio_fr #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @hkchekc! Thanks for updating the PR.
Comment last updated on December 06, 2018 at 15:58 Hours UTC |
1 similar comment
Hi @hkchekc! Thanks for adding some more tests! |
And you need to inherit from |
One test will fail now due to a bug which will be fixed in the PR #581 |
@hkchekc: You will also need to adjust the conversion of nix attributes to regular python objects, because nix objects are not supported by neo eg. as annotations. |
We upload a new nix file for test on Gin. |
I merged the new file and rerun the tests. However, they are still failing somewhere within nix when parsing the header. Do you have an idea how to fix this? |
@hkchekc: Thanks for fixing the CI tests. Failure
File .../python-neo/neo/rawio/tests/common_rawio_test.py", line 151, in test_read_all
compliance.read_analogsignals(reader)
File ".../python-neo/neo/rawio/tests/rawio_compliance.py", line 144, in read_analogsignals
assert raw_chunk.ndim == 2
AssertionError It seems that |
@JuliaSprenger I try to use numpy 1.15.1 and nixio 1.5.0b2 to run the test_nixio_fr.py and test_nixrawio.py for both 'nixrawio-1.5.nix' and ' nixio_fr.nix' and could not reproduce the error. Can you tell me more details? I used Python3.5 and 3.7 |
Hi @hkchekc, |
Thanks for all the checkings! @JuliaSprenger |
in Reference to Issue #575 , some basic test for nixio_fr and compatability test of nixio and nixio_fr is added.