Skip to content

Conversation

mdenker
Copy link
Member

@mdenker mdenker commented Nov 15, 2018

This fixes an issue in the older BlackrockIO related to the handling of sting decode() operations in Python3.

For old file versions, the units of the raw signal are hard-coded as microvolts. This string needs to be a b'uV' for Python 3 to work with a later decode() operation on that string.

@mdenker mdenker added the bug label Nov 15, 2018
@mdenker mdenker added this to the 0.7.0 milestone Nov 15, 2018
@mdenker mdenker self-assigned this Nov 15, 2018
@mdenker mdenker requested a review from apdavison November 15, 2018 16:42
@pep8speaks
Copy link

Hello @mdenker! Thanks for submitting the PR.

Line 281:68: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1111:13: W504 line break after binary operator
Line 1270:17: W504 line break after binary operator
Line 1280:17: W504 line break after binary operator
Line 1281:17: W504 line break after binary operator
Line 1313:17: W504 line break after binary operator
Line 1316:17: W504 line break after binary operator
Line 1339:17: W504 line break after binary operator
Line 1413:21: W504 line break after binary operator
Line 1454:21: W504 line break after binary operator
Line 1661:17: E129 visually indented line with same indent as next logical line
Line 1661:17: W503 line break before binary operator
Line 1724:38: E126 continuation line over-indented for hanging indent
Line 1829:21: W504 line break after binary operator
Line 1830:21: W504 line break after binary operator
Line 2011:46: E126 continuation line over-indented for hanging indent
Line 2013:42: E126 continuation line over-indented for hanging indent
Line 2015:42: E126 continuation line over-indented for hanging indent
Line 2030:44: W504 line break after binary operator
Line 2030:48: E126 continuation line over-indented for hanging indent
Line 2031:44: E131 continuation line unaligned for hanging indent
Line 2037:44: W504 line break after binary operator
Line 2037:48: E126 continuation line over-indented for hanging indent
Line 2038:44: E131 continuation line unaligned for hanging indent
Line 2054:44: E126 continuation line over-indented for hanging indent
Line 2056:44: E126 continuation line over-indented for hanging indent
Line 2562:100: E501 line too long (104 > 99 characters)

Line 34:33: W504 line break after binary operator
Line 35:33: W504 line break after binary operator

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.224% when pulling 05d47fa on INM-6:fix/blackrockiopy3 into 937946b on NeuralEnsemble:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.224% when pulling 05d47fa on INM-6:fix/blackrockiopy3 into 937946b on NeuralEnsemble:master.

@JuliaSprenger JuliaSprenger merged commit de8b590 into NeuralEnsemble:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants