[Update to PR #662] fix duplication of array_annotations into annotations #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling Issue #748
The issue arises from this part of the loading routine which adds properties which are an array_annotation to a corresponding nested dict within neo_attrs, but also adds them as a regular annotation, therefore creating a duplicate.
nixio.py line 1237-1244 (in method _nix_attr_to_neo):
It seems that PR #662 intended not to duplicate the array_annotations, but the duplication was then introduced with the merge commit 0a4ccfa
Please comment @Kleinjohann ?
The PR separates the properties again, to be either stored directly in neo_attrs, or in neo_attrs['array_annotations'] but not both.