Reenable Filtering Events and Epochs by Labels #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaSprenger
approved these changes
Mar 31, 2020
|
I noticed some issues in the examples in the docstrings of |
JuliaSprenger
approved these changes
Apr 3, 2020
|
Looks good to me, if there is no further comments I would like to merge soon. |
|
I don't remember. |
|
This feature was automatically covered when labels were handled as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the tests of the utils module filtering events and epochs using labels or any other regular attributes is not covered. #659 broke filtering by labels, but this wasn't noticed of course since the tests are missing.
I fixed filtering by labels and added tests for labels and regular attributes.