-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #21
Refactoring #21
Conversation
|
Otherwise, this looks great to me! The code makes sense. If there are any remaining edge cases to catch, we can handle those in separate PRs/commits. |
@rly yes I think i'd rather use pip -- a PR to clean this up is very welcome |
There are too many changes here to review as a diff, because the classes were all renamed and reorganized.
The main change was to have the LindiH5pyFile be a subclass of h5py.File
Similarly, LindiH5pyGroup is a subclass of h5py.Group and LindiH5pyDataset is a subset of h5py.Dataset
This allows a LindiH5pyFile client to be used with pynwb just like a h5py.File client.
@rly rather than review the diff, I recommend that you look at this branch, with the updated README.md and new examples.
https://github.com/NeurodataWithoutBorders/lindi/tree/refactor