Set H5S_NULL if the data is not chunked and is empty. #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While investigating #434 it seems that
colnames
is not writable if it is empty. This is technically allowable given the schema simply listing its shape as one-dimensional with no bounds. However, callingio.writeAttribute
appears to result in an unknown HDF5 error, perhaps because the dimensions are set to zero.The solution right now is something like h5py/h5py#279 when the dataset is actually empty. Not sure how this would need to work for chunked datasets as these can be amended.
How to test the behavior?
Running the example in this comment should work:
#434 (comment)
Checklist
fix #XX
whereXX
is the issue number?